Bruce Momjian [Wed, 31 Mar 2004 16:20:53 +0000 (16:20 +0000)]
Back out tutorial changes:
---------------------------------------------------------------------------
1. In keeping with the recent discussion that there should be more
said about views, stored procedures, and triggers, in the tutorial, I
have added a bit of verbiage to that end.
2. Some formatting changes to the datetime discussion, as well as
addition of a citation of a relevant book on calendars.
Christopher Browne
Bruce Momjian [Wed, 31 Mar 2004 01:05:54 +0000 (01:05 +0000)]
Add psql backslash command discussion.
Bruce Momjian [Wed, 31 Mar 2004 01:04:49 +0000 (01:04 +0000)]
Add:
* Move psql backslash database information into the backend, use
nmumonic commands? [psql]
Bruce Momjian [Wed, 31 Mar 2004 01:01:38 +0000 (01:01 +0000)]
Remove:
* Prevent unneeded quoting in psql \d output using fmtId()
Bruce Momjian [Tue, 30 Mar 2004 22:08:50 +0000 (22:08 +0000)]
Fix markup errors from recent patch.
Bruce Momjian [Tue, 30 Mar 2004 21:58:20 +0000 (21:58 +0000)]
1. In keeping with the recent discussion that there should be more
said about views, stored procedures, and triggers, in the tutorial, I
have added a bit of verbiage to that end.
2. Some formatting changes to the datetime discussion, as well as
addition of a citation of a relevant book on calendars.
Christopher Browne
Bruce Momjian [Tue, 30 Mar 2004 21:51:41 +0000 (21:51 +0000)]
Add:
> * Add GUC variable to allow output of interval values in ISO8601 format
Bruce Momjian [Tue, 30 Mar 2004 15:54:33 +0000 (15:54 +0000)]
Add mention of how to use \df to find functions using/returning specific
data types.
Bruce Momjian [Tue, 30 Mar 2004 15:53:18 +0000 (15:53 +0000)]
Fix to_char for 1 BC. Previously it returned 1 AD.
Fix to_char(year) for BC dates. Previously it returned one less than
the current year.
Add documentation mentioning that there is no 0 AD.
Teodor Sigaev [Tue, 30 Mar 2004 15:45:33 +0000 (15:45 +0000)]
Cleanup vectors of GISTENTRY and eliminate problem with 64-bit strict-aligned
boxes. Change interface to user-defined GiST support methods union and
picksplit. Now instead of bytea struct it used special GistEntryVector
structure.
Tom Lane [Mon, 29 Mar 2004 19:58:04 +0000 (19:58 +0000)]
Use fuzzy comparison of path costs in add_path(), so that paths with the
same path keys and nearly equivalent costs will be considered redundant.
The exact nature of the fuzziness may get adjusted later based on current
discussions, but no one has shot a hole in the basic idea yet ...
Michael Meskes [Mon, 29 Mar 2004 15:11:58 +0000 (15:11 +0000)]
Fixed possible segfault in type.c (by Juergen Cappel)
Bruce Momjian [Mon, 29 Mar 2004 05:07:20 +0000 (05:07 +0000)]
Update FAQ from Robert Treat
Tom Lane [Sun, 28 Mar 2004 06:09:08 +0000 (06:09 +0000)]
Some further editorializing on README.CVS.
Bruce Momjian [Sun, 28 Mar 2004 02:37:31 +0000 (02:37 +0000)]
Clean up thread test program.
Bruce Momjian [Sat, 27 Mar 2004 23:02:44 +0000 (23:02 +0000)]
Add test for thread-safe errno to thread test program.
Bruce Momjian [Sat, 27 Mar 2004 18:01:40 +0000 (18:01 +0000)]
Add comment about psql \s (history display):
/* This scrolls off the screen when using /dev/tty */
Bruce Momjian [Sat, 27 Mar 2004 17:59:35 +0000 (17:59 +0000)]
Clean up function call arg appearance.
Bruce Momjian [Sat, 27 Mar 2004 17:32:42 +0000 (17:32 +0000)]
Change small 'if/else' test to use Max().
Tom Lane [Sat, 27 Mar 2004 03:08:42 +0000 (03:08 +0000)]
Fix brain-dead placement of global variable declaration.
Tom Lane [Sat, 27 Mar 2004 00:24:28 +0000 (00:24 +0000)]
Now that we are allowing index opclasses to contain operators that are
only stable and not immutable, pred_test_simple_clause has to guard
against making invalid deductions. Add a test for immutability of
the selected test_op.
Bruce Momjian [Fri, 26 Mar 2004 18:24:08 +0000 (18:24 +0000)]
Add -D_REENTRANT for Solaris threading.
Neil Conway [Fri, 26 Mar 2004 03:18:28 +0000 (03:18 +0000)]
More cross-reference work, other minor SGML fixes and improvements.
Bruce Momjian [Thu, 25 Mar 2004 22:12:37 +0000 (22:12 +0000)]
Update gcc solaris flags.
Bruce Momjian [Thu, 25 Mar 2004 21:48:59 +0000 (21:48 +0000)]
Fix for SSL compile.
Tom Lane [Thu, 25 Mar 2004 18:57:57 +0000 (18:57 +0000)]
Convert some GUC variable references to links.
Teodor Sigaev [Thu, 25 Mar 2004 16:56:10 +0000 (16:56 +0000)]
1 Minimize memory allocation for void (but not null) value.
2 Add silly ordering for ts_vector to aim grouping, union, except etc. Don't use BTree opclass (tsvector_ops).
Tom Lane [Wed, 24 Mar 2004 23:38:49 +0000 (23:38 +0000)]
Add a more useful error message for the case where someone tries to pass
a whole row or record variable into a SQL function. Eventually this case
should be made to actually work, but for now this is better than what it
did before.
Tom Lane [Wed, 24 Mar 2004 22:40:29 +0000 (22:40 +0000)]
Replace max_expr_depth parameter with a max_stack_depth parameter that
is measured in kilobytes and checked against actual physical execution
stack depth, as per my proposal of 30-Dec. This gives us a fairly
bulletproof defense against crashing due to runaway recursive functions.
Bruce Momjian [Wed, 24 Mar 2004 18:15:56 +0000 (18:15 +0000)]
Add:
* Have pg_dump use multi-statement transactions for INSERT dumps
Tom Lane [Wed, 24 Mar 2004 15:20:54 +0000 (15:20 +0000)]
Adjust error message wording per Andrew Dunstan's advice.
Neil Conway [Wed, 24 Mar 2004 09:49:20 +0000 (09:49 +0000)]
Make a cross-reference in the ALTER TABLE ref page into a <xref>.
Bruce Momjian [Wed, 24 Mar 2004 04:07:31 +0000 (04:07 +0000)]
Update description error text:
(errmsg("no socket configured for listening")));
Bruce Momjian [Wed, 24 Mar 2004 04:04:51 +0000 (04:04 +0000)]
Here's a patch implementing the "thread method" to workaround the bug
with socket calls in signal handlers (APC) on Win32. See details in mail
to pgsql-hackers-win32 a couple of minutes ago.
Magnus Hagander
Bruce Momjian [Wed, 24 Mar 2004 03:54:16 +0000 (03:54 +0000)]
Allow unlink/rename of files open by another process on Win32, using a
special Win32 open flag FILE_SHARE_DELETE.
Claudio Natoli
Neil Conway [Wed, 24 Mar 2004 03:48:41 +0000 (03:48 +0000)]
Fix a minor typo in the log_line_prefix docs and make a couple other
tiny improvements.
Bruce Momjian [Wed, 24 Mar 2004 03:45:00 +0000 (03:45 +0000)]
Add thread locking to SSL and Kerberos connections.
I have removed the docs mentioning that SSL and Kerberos are not
thread-safe.
Manfred Spraul
Bruce Momjian [Wed, 24 Mar 2004 03:27:46 +0000 (03:27 +0000)]
Document fallback to tcp/ip localhost connection from psql on ports
without unix domain sockets (win32).
Neil Conway [Wed, 24 Mar 2004 03:22:35 +0000 (03:22 +0000)]
Fix some whitespace formatting, and remove an overly-verbose
parameter description: postgresql.conf is not the place for
documentating the functionality of a GUC var.
Bruce Momjian [Wed, 24 Mar 2004 03:10:29 +0000 (03:10 +0000)]
>>Also, what is the default connection mode of psql? It should probably be
>>equivalent to "-h localhost", shouldn't it?
>>
>>
>
>Now that is something I had not thought of. Seems we can assume a Win32
>psql can never use unix domain sockets, so defaulting that to localhost
>is a good solution too.
Andrew Dunstan
Bruce Momjian [Wed, 24 Mar 2004 03:06:08 +0000 (03:06 +0000)]
Use the new GUC variable default_with_oids in pg_dump, rather than using
WITH/WITHOUT OIDS in dump files. This makes dump files more portable.
I have updated the pg_dump version so old binary dumps will load fine.
Pre-7.5 dumps use WITHOUT OIDS in SQL were needed, so they should be
fine.
Neil Conway [Wed, 24 Mar 2004 02:02:27 +0000 (02:02 +0000)]
Update the float8 regression tests: they should now pass on FreeBSD 4.x
and (in theory) QNX. Thanks to Chris KL for the report.
Tom Lane [Tue, 23 Mar 2004 23:37:17 +0000 (23:37 +0000)]
PQresult should be PGresult.
Tom Lane [Tue, 23 Mar 2004 22:57:09 +0000 (22:57 +0000)]
Fix small typo.
Tom Lane [Tue, 23 Mar 2004 22:39:22 +0000 (22:39 +0000)]
Repair misleading description of MOVE's command tag result.
Tom Lane [Tue, 23 Mar 2004 22:06:08 +0000 (22:06 +0000)]
Use dollar-quoting for function bodies, unless disabled with
--disable-dollar-quoting.
Andrew Dunstan
Bruce Momjian [Tue, 23 Mar 2004 21:39:46 +0000 (21:39 +0000)]
When changing select() calls for delays into pg_usleep(), two comments
in s_lock.c were not updated, and still refers to select. Made my grep
hit the wrong files, so I figured a simple patch was in order.. (other
refs in the same comment block was changed..)
Magnus Hagander
Tom Lane [Tue, 23 Mar 2004 19:35:17 +0000 (19:35 +0000)]
Upgrade ALTER TABLE DROP COLUMN so that it can drop an OID column, and
remove separate implementation of ALTER TABLE SET WITHOUT OIDS in favor
of doing a regular DROP. Also, cause CREATE TABLE to account completely
correctly for the inheritance status of the OID column. This fixes
problems with dropping OID columns that have dependencies, as noted by
Christopher Kings-Lynne, as well as making sure that you can't drop an
OID column that was inherited from a parent.
Neil Conway [Tue, 23 Mar 2004 13:21:41 +0000 (13:21 +0000)]
Minor SGML improvements.
Neil Conway [Tue, 23 Mar 2004 06:09:00 +0000 (06:09 +0000)]
Fix typo in postmaster reference page: from Tom.
Bruce Momjian [Tue, 23 Mar 2004 05:26:53 +0000 (05:26 +0000)]
fflush() FILE buffer to descriptor so stat call gets proper size in fseeko.c.
Fixed problem with pg_dump tar backups. Only happens on platforms that
use our port/fseeko.c, which is currently BSD/OS and NetBSD.
Neil Conway [Tue, 23 Mar 2004 02:47:35 +0000 (02:47 +0000)]
Improve the locale and character set docs, add some <xref>s pointing
to the character set docs where appropriate, and improve the postmaster
reference page. Character set cross-refs suggested by Gavin Kistner.
Bruce Momjian [Tue, 23 Mar 2004 02:03:55 +0000 (02:03 +0000)]
Fix getpwuid_r call:
*result = getpwuid_r(uid, resultbuf, buffer, buflen);
Tom Lane [Tue, 23 Mar 2004 01:23:48 +0000 (01:23 +0000)]
Replace the virtual_host and tcpip_socket parameters with a unified
listen_addresses parameter, as per recent discussion. The default behavior
is now to listen on localhost, which eliminates the need for the -i
postmaster switch in many scenarios.
Andrew Dunstan
Tom Lane [Mon, 22 Mar 2004 23:55:29 +0000 (23:55 +0000)]
Before deciding we can use a socket for statistics collection, test to
ensure that it actually passes data. This catches cases such as a kernel
packet filter rule that makes the socket useless.
Andrew Dunstan
Tom Lane [Mon, 22 Mar 2004 16:46:28 +0000 (16:46 +0000)]
Add missing extern for optind.
Tom Lane [Mon, 22 Mar 2004 16:18:50 +0000 (16:18 +0000)]
Clean up rather poor description of the difference between INHERITS and
LIKE. Per gripe from Patrick Samson.
Tom Lane [Mon, 22 Mar 2004 15:34:22 +0000 (15:34 +0000)]
Standardize output buffer size and display format for strftime;
followup to complaint from Korean User's Group.
Bruce Momjian [Mon, 22 Mar 2004 14:53:43 +0000 (14:53 +0000)]
Disasble threads on unixware until other platforms report a problem.
Bruce Momjian [Mon, 22 Mar 2004 04:16:57 +0000 (04:16 +0000)]
Increase xlog str_time() static string variable, per Korean User's Group.
Bruce Momjian [Mon, 22 Mar 2004 03:57:08 +0000 (03:57 +0000)]
In working through a pg_autovacuum problem with Joe Conway (which turned
out to be the same problem reported by Cott Lang which the previous
patch resolved) a new bug was uncovered when running with a debug level
of greater than 1.
This patch resolves this new found bug and fixes some of the other
debugging output to be more consistent.
Please apply to both HEAD and the 7.4 branch.
Matthew T. O'Connor
Bruce Momjian [Mon, 22 Mar 2004 03:38:24 +0000 (03:38 +0000)]
I just noticed that \dp outputs "Table" to indicate relations (tables,
sequences and views). This patch allows it to handle views and
sequences.
Euler Taveira de Oliveira
Bruce Momjian [Mon, 22 Mar 2004 03:15:33 +0000 (03:15 +0000)]
Adds DLLIMPORT modifier to check_function_bodies
Claudio Natoli
Bruce Momjian [Mon, 22 Mar 2004 01:50:31 +0000 (01:50 +0000)]
Add mention of "-D_POSIX_PTHREAD_SEMANTICS" enabling 5-arg getpwuid_r().
Tom Lane [Mon, 22 Mar 2004 01:38:18 +0000 (01:38 +0000)]
Add timestamp-versus-timestamptz cross-type comparison functions,
flesh out the index operator classes to include these. In passing,
fix erroneous volatility marking of ACL functions.
Tom Lane [Sun, 21 Mar 2004 22:29:11 +0000 (22:29 +0000)]
Revise syntax-error reporting behavior to give pleasant results for
errors in internally-generated queries, such as those submitted by
plpgsql functions. Per recent discussions with Fabien Coelho.
Dennis Bjorklund [Sun, 21 Mar 2004 12:19:36 +0000 (12:19 +0000)]
Translation updates
Dennis Bjorklund [Sun, 21 Mar 2004 09:22:18 +0000 (09:22 +0000)]
Translation updates
Tom Lane [Sat, 20 Mar 2004 20:09:45 +0000 (20:09 +0000)]
Rewrite pg_dump's comment-dumping code to pull over all the comments
in one query, rather than making a separate query for each object that
could have a comment. This costs relatively little space (a few tens of
K typically) and saves substantial time in databases with many objects.
I find it reduces the runtime of 'pg_dump -s regression' by about a
third.
Bruce Momjian [Sat, 20 Mar 2004 16:18:41 +0000 (16:18 +0000)]
Remove suggestiong for using test for wal_sync_method.
Bruce Momjian [Sat, 20 Mar 2004 16:11:22 +0000 (16:11 +0000)]
Always test getpwuid_r because HEAD always uses *_r if it finds them.
Not an issue for 7.4.X.
Bruce Momjian [Sat, 20 Mar 2004 15:39:27 +0000 (15:39 +0000)]
Handle draft version of getpwuid_r() that accepts only four arguments.
Backpatch to 7.4.X. Required for Solaris 7 & 8.
Tom Lane [Fri, 19 Mar 2004 19:13:26 +0000 (19:13 +0000)]
Add a usage example for has_function_privilege().
Tom Lane [Fri, 19 Mar 2004 18:58:07 +0000 (18:58 +0000)]
Create a validator for plpgsql, so that some minimal syntax checking
is done at creation time for plpgsql functions. Improve createlang and
droplang to support adding/dropping validators for PLs. Initial steps
towards producing a syntax error position from plpgsql syntax errors
(this part is a work in progress, and will change depending on outcome
of current discussions).
Tom Lane [Fri, 19 Mar 2004 02:23:59 +0000 (02:23 +0000)]
Code review for log_line_prefix patch. Cooperate with StringInfo instead
of fighting it, avoid hard-wired (and wrong) assumption about max length
of prefix, cause %l to actually work as documented, don't compute data
we may not need.
Bruce Momjian [Thu, 18 Mar 2004 23:27:29 +0000 (23:27 +0000)]
Make test_fsync use optimizer flag.
Bruce Momjian [Thu, 18 Mar 2004 23:26:17 +0000 (23:26 +0000)]
Fix log_executor_stats if() test.
Bruce Momjian [Thu, 18 Mar 2004 23:23:58 +0000 (23:23 +0000)]
Add Unixware thread support from Larry Rosenman.
Bruce Momjian [Thu, 18 Mar 2004 20:09:33 +0000 (20:09 +0000)]
Allocate 16mb file for testing.
Bruce Momjian [Thu, 18 Mar 2004 19:54:00 +0000 (19:54 +0000)]
Have program default to 1000 loops, and add file name and loop option.
Make open/close loop testings the same. Add descriptions for certain tests.
Bruce Momjian [Thu, 18 Mar 2004 17:23:56 +0000 (17:23 +0000)]
Add comment about using this testing for wal_sync_method.
Bruce Momjian [Thu, 18 Mar 2004 15:26:27 +0000 (15:26 +0000)]
Add fsync tests:
Compare fsync before and after write's close:
Compare one o_sync write to two:
Compare file sync methods with one 8k write:
Compare file sync methods with 2 8k writes:
Bruce Momjian [Thu, 18 Mar 2004 14:02:58 +0000 (14:02 +0000)]
Mention which fsync methods are unavailable.
Bruce Momjian [Thu, 18 Mar 2004 04:11:41 +0000 (04:11 +0000)]
Add permission mode to opens().
Bruce Momjian [Thu, 18 Mar 2004 04:04:36 +0000 (04:04 +0000)]
Add missing include
Bruce Momjian [Thu, 18 Mar 2004 03:57:58 +0000 (03:57 +0000)]
Remove acccidental object/binary files.
Bruce Momjian [Thu, 18 Mar 2004 03:56:59 +0000 (03:56 +0000)]
Add fsync test program. It tests fsync to see if times for fsync are the
same when done on the write() ile descriptor and a new descriptor.
it also times various fsync methods.
Bruce Momjian [Wed, 17 Mar 2004 22:30:10 +0000 (22:30 +0000)]
Done:
> * -Order duplicate index entries on creation by tid for faster heap lookups
Tom Lane [Wed, 17 Mar 2004 22:24:58 +0000 (22:24 +0000)]
During btree index build, sort equal-keyed tuples according to their
TID (heap position). This doesn't do anything to the validity of the
finished index, but by pretending to qsort() that there are no really
equal keys in the sort, we can avoid performance problems with qsort
implementations that have trouble with large numbers of equal keys.
Patch from Manfred Koizar.
Tom Lane [Wed, 17 Mar 2004 20:48:43 +0000 (20:48 +0000)]
Reimplement CASE val WHEN compval1 THEN ... WHEN compval2 THEN ... END
so that the 'val' is computed only once, per recent discussion. The
speedup is not much when 'val' is just a simple variable, but could be
significant for larger expressions. More importantly this avoids issues
with multiple evaluations of a volatile 'val', and it allows the CASE
expression to be reverse-listed in its original form by ruleutils.c.
Bruce Momjian [Wed, 17 Mar 2004 17:40:44 +0000 (17:40 +0000)]
Modify:
< * Order duplicate index entries by tid for faster heap lookups
> * Order duplicate index entries on creation by tid for faster heap lookups
Bruce Momjian [Wed, 17 Mar 2004 01:05:10 +0000 (01:05 +0000)]
Document SPI_push() and SPI_pop().
Tom Lane [Wed, 17 Mar 2004 01:02:24 +0000 (01:02 +0000)]
Replace the switching function ExecEvalExpr() with a macro that jumps
directly to the appropriate per-node execution function, using a function
pointer stored by ExecInitExpr. This speeds things up by eliminating one
level of function call. The function-pointer technique also enables further
small improvements such as only making one-time tests once (and then
changing the function pointer). Overall this seems to gain about 10%
on evaluation of simple expressions, which isn't earthshaking but seems
a worthwhile gain for a relatively small hack. Per recent discussion
on pghackers.
Bruce Momjian [Tue, 16 Mar 2004 16:13:38 +0000 (16:13 +0000)]
Add:
> * Allow pg_dumpall to use non-text output formats
>
Bruce Momjian [Tue, 16 Mar 2004 05:05:58 +0000 (05:05 +0000)]
Remove double-rename used by Win32 on busy files. Not needed anymore.
Bruce Momjian [Mon, 15 Mar 2004 17:57:51 +0000 (17:57 +0000)]
log_statement was not removed by the previous patch. It only updated
its description.
Bruce Momjian [Mon, 15 Mar 2004 16:27:43 +0000 (16:27 +0000)]
The "cvs add" of test_thread_implicit.pgc seems to have been missed,
i've attached this again.
Additionally I include a small patch to remove mutex locking when a
DEFAULT/NULL connection is being retrieved. This is consistent with
libpq.
Lee Kindness
Bruce Momjian [Mon, 15 Mar 2004 16:21:37 +0000 (16:21 +0000)]
Check for EOF on pipe differs under win32, as it is based on a socket
implementation.
Claudio Natoli
Bruce Momjian [Mon, 15 Mar 2004 16:20:52 +0000 (16:20 +0000)]
float8-small-is-zero and float8-exp-three-digits will likely need
similar changes.
Claudio Natoli
Bruce Momjian [Mon, 15 Mar 2004 16:18:43 +0000 (16:18 +0000)]
* postc: cleanup pmdaemonize under win32; missed failure message
in CreateOptsFile
* s_lock.c: minor comment fix
* findbe.c: variables not used under win32 moved within #ifndef WIN32
case
Claudio Natoli