Tom Lane [Wed, 15 Dec 2004 20:15:17 +0000 (20:15 +0000)]
Disallow SETOF in the input of parseTypeString(). Formerly it was
silently ignored, allowing one to write bizarre things like
DECLARE x setof int;
in plpgsql. This has misled at least one novice into thinking that
plpgsql variables could be sets ...
Tom Lane [Wed, 15 Dec 2004 19:16:39 +0000 (19:16 +0000)]
Calculation of keys_are_unique flag was wrong for cases involving
redundant cross-datatype comparisons. Per example from Merlin Moncure.
Peter Eisentraut [Wed, 15 Dec 2004 17:50:20 +0000 (17:50 +0000)]
New translations
Peter Eisentraut [Wed, 15 Dec 2004 17:39:54 +0000 (17:39 +0000)]
Translation updates
Peter Eisentraut [Wed, 15 Dec 2004 17:14:11 +0000 (17:14 +0000)]
Translation update
Bruce Momjian [Wed, 15 Dec 2004 03:11:26 +0000 (03:11 +0000)]
Update IRC mention.
Tom Lane [Tue, 14 Dec 2004 22:50:23 +0000 (22:50 +0000)]
In 'make installcheck' for contrib/, insert 'sleep 1' between subdirectory
checks, to ensure the previous test backend has time to quit out of the
regression database. Also, allow all the checks to be run even if one
of them fails. Per suggestions from Andrew Dunstan to improve the
usefulness of buildfarm testing.
Tom Lane [Tue, 14 Dec 2004 22:16:32 +0000 (22:16 +0000)]
Cope with circularities involving a view's ON SELECT rule. I originally
thought there couldn't be any, but the folly of this was exposed by an
example from andrew@supernews.com 5-Dec-2004. The patch applies the
identical logic already used for table constraints and defaults to ON
SELECT rules, so I have reasonable confidence in it even though it might
look like complicated logic.
Tom Lane [Tue, 14 Dec 2004 21:35:20 +0000 (21:35 +0000)]
Fix pg_dump to ensure that a comment on a table CHECK constraint cannot
be emitted too soon. The previous code got this right in the case where
the CHECK was emitted as a separate ALTER TABLE command, but not in the
case where the CHECK is emitted right in CREATE TABLE. Per report from
Slawomir Sudnik.
Note: this code is pretty ugly; it'd perhaps be better to treat comments
as independently sortable dump objects. That'd be much too invasive a
change for RC time though.
Bruce Momjian [Tue, 14 Dec 2004 14:53:53 +0000 (14:53 +0000)]
Update aix cc_r wording.
Bruce Momjian [Tue, 14 Dec 2004 12:58:29 +0000 (12:58 +0000)]
Mention aix cc_r is not supported, and why
Peter Eisentraut [Tue, 14 Dec 2004 11:11:20 +0000 (11:11 +0000)]
Fix typo
Peter Eisentraut [Tue, 14 Dec 2004 10:24:27 +0000 (10:24 +0000)]
Add port reports
Neil Conway [Tue, 14 Dec 2004 01:59:41 +0000 (01:59 +0000)]
Prevent pg_resetxlog from being run as root. If this is allowed, some
root-owned files will be written to the data directory, leaving it in an
unusable state.
Peter Eisentraut [Tue, 14 Dec 2004 00:36:12 +0000 (00:36 +0000)]
Add more port reports.
Peter Eisentraut [Mon, 13 Dec 2004 22:54:20 +0000 (22:54 +0000)]
New translation
Peter Eisentraut [Mon, 13 Dec 2004 21:49:10 +0000 (21:49 +0000)]
Translation updates
Bruce Momjian [Mon, 13 Dec 2004 18:40:30 +0000 (18:40 +0000)]
Remove:
< o Allow the shared memory address to be configured via GUC
Peter Eisentraut [Mon, 13 Dec 2004 18:05:10 +0000 (18:05 +0000)]
Spell checker run
Bruce Momjian [Mon, 13 Dec 2004 18:00:51 +0000 (18:00 +0000)]
Done:
< o Remove per-backend parameter file and move into shared memory
Add for Win32:
> o Allow the shared memory address to be configured via GUC
Bruce Momjian [Mon, 13 Dec 2004 17:28:54 +0000 (17:28 +0000)]
Clearify which version numbers are bumped for major and minor releases.
Peter Eisentraut [Mon, 13 Dec 2004 16:30:53 +0000 (16:30 +0000)]
New translations
Peter Eisentraut [Mon, 13 Dec 2004 16:28:23 +0000 (16:28 +0000)]
Translation updates
Bruce Momjian [Mon, 13 Dec 2004 14:21:32 +0000 (14:21 +0000)]
Add:
>
> * Allow the size of the buffer cache used by temporary objects to be
> specified as a GUC variable
>
> Larger local buffer cache sizes requires more efficient handling of
> local cache lookups.
Bruce Momjian [Mon, 13 Dec 2004 03:37:09 +0000 (03:37 +0000)]
Update FAQ.
Euler Taveira de Oliveira
Tom Lane [Mon, 13 Dec 2004 00:33:06 +0000 (00:33 +0000)]
Avoid generating excess (and illegal) parentheses around an aliased JOIN
in prettyprint mode. Andreas Pflug
Neil Conway [Sun, 12 Dec 2004 22:49:50 +0000 (22:49 +0000)]
Add regression tests for the fix committed by Tom for casting between
the row types of parent/child tables.
Tom Lane [Sun, 12 Dec 2004 20:17:06 +0000 (20:17 +0000)]
PREPARE and EXPLAIN need to copy the source query just like we recently
had to do in DECLARE CURSOR. AFAICS these are all the places affected.
PREPARE case per example from Michael Fuhr, EXPLAIN case located by
grepping for planner calls ...
Peter Eisentraut [Sun, 12 Dec 2004 18:26:29 +0000 (18:26 +0000)]
Add missing newlines at end of error messages.
Peter Eisentraut [Sun, 12 Dec 2004 18:09:18 +0000 (18:09 +0000)]
Translation updates
Peter Eisentraut [Sun, 12 Dec 2004 15:34:15 +0000 (15:34 +0000)]
Fix problems with certain shells (e.g., FreeBSD, Cygwin) clearing the
exit status in multiline traps.
Tom Lane [Sun, 12 Dec 2004 05:07:50 +0000 (05:07 +0000)]
Upgrade formrdesc() so that it can correctly initialize the tupledesc
(rd_att) field of a nailed-in-cache relcache entry. This fixes the bug
reported by Alvaro 8-Dec-2004; I believe it probably also explains
Grant Finnemore's report of 10-Sep-2004.
In an unrelated change in the same file, put back 7.4's response to
failure to rename() the relcache init file, ie, unlink the useless
temp file. I did not put back the warning message, since there might
actually be some reason not to have that.
Tom Lane [Sat, 11 Dec 2004 23:26:51 +0000 (23:26 +0000)]
Instead of supposing (wrongly, in the general case) that the rowtype
of an inheritance child table is binary-compatible with the rowtype of
its parent, invent an expression node type that does the conversion
correctly. Fixes the new bug exhibited by Kris Shannon as well as a
lot of old bugs that would only show up when using multiple inheritance
or after altering the parent table.
Peter Eisentraut [Sat, 11 Dec 2004 20:54:14 +0000 (20:54 +0000)]
Added port reports
Peter Eisentraut [Sat, 11 Dec 2004 20:19:24 +0000 (20:19 +0000)]
Translation updates
Peter Eisentraut [Sat, 11 Dec 2004 20:10:14 +0000 (20:10 +0000)]
Translation updates
Peter Eisentraut [Sat, 11 Dec 2004 20:03:37 +0000 (20:03 +0000)]
Patch to the pl/perl documents that clarifies the scope of global data and
gives an example of storing a code reference
by David Fetter
Peter Eisentraut [Sat, 11 Dec 2004 19:56:07 +0000 (19:56 +0000)]
Translation updates
Peter Eisentraut [Sat, 11 Dec 2004 19:45:34 +0000 (19:45 +0000)]
Translation updates
Peter Eisentraut [Sat, 11 Dec 2004 19:31:45 +0000 (19:31 +0000)]
Added port reports
Peter Eisentraut [Sat, 11 Dec 2004 19:13:32 +0000 (19:13 +0000)]
Added port report
Peter Eisentraut [Sat, 11 Dec 2004 19:09:08 +0000 (19:09 +0000)]
Translation updates
Peter Eisentraut [Sat, 11 Dec 2004 19:03:49 +0000 (19:03 +0000)]
Translation updates
Peter Eisentraut [Sat, 11 Dec 2004 19:01:46 +0000 (19:01 +0000)]
Added port report
Bruce Momjian [Fri, 10 Dec 2004 18:01:59 +0000 (18:01 +0000)]
Reorder IRC examples.
Tom Lane [Mon, 6 Dec 2004 23:57:17 +0000 (23:57 +0000)]
ActiveSnapshot must be set to something valid while running deferred
triggers during COMMIT. Per trouble report from Frank van Vugt.
Peter Eisentraut [Mon, 6 Dec 2004 23:47:08 +0000 (23:47 +0000)]
Start filling in the supported platforms list with build farm information.
Peter Eisentraut [Mon, 6 Dec 2004 22:10:42 +0000 (22:10 +0000)]
Translation updates
Michael Meskes [Mon, 6 Dec 2004 20:35:35 +0000 (20:35 +0000)]
Fixed bug in parsing of typedef'ed array sizes.
Synced parser.
Neil Conway [Mon, 6 Dec 2004 01:09:20 +0000 (01:09 +0000)]
Fix off-by-1 bug in pg_ctl in -D handling, per report from pjmodos@parba.cz
Tom Lane [Sun, 5 Dec 2004 20:05:47 +0000 (20:05 +0000)]
Fix several mistaken xreflabel entries, including those spotted by
Michael Fuhr.
Bruce Momjian [Sat, 4 Dec 2004 18:19:33 +0000 (18:19 +0000)]
Back out addition of Win1252 encoding.
Bruce Momjian [Sat, 4 Dec 2004 04:12:11 +0000 (04:12 +0000)]
Properl format HTML in developer's FAQ.
PostgreSQL Daemon [Fri, 3 Dec 2004 22:24:53 +0000 (22:24 +0000)]
tag configure for rc1 ..
Tom Lane [Fri, 3 Dec 2004 22:19:28 +0000 (22:19 +0000)]
As long as we're forcing an ORDER BY in these four join queries, we had
better make sure the sort order is totally specified; else we get burnt
by platform-specific behavior of qsort() with equal keys. Per buildfarm
results.
Tom Lane [Fri, 3 Dec 2004 21:26:31 +0000 (21:26 +0000)]
Use StrNCpy not strncpy to fill hash key, to ensure the resulting key
is null-terminated. I think this is not a real bug because the parser
would always have truncated the identifier to NAMEDATALEN-1 already,
but let's be safe. Per report from Klocwork.
Tom Lane [Fri, 3 Dec 2004 18:48:19 +0000 (18:48 +0000)]
Adjust help message for --no-owner, per Alvaro Herrera.
Bruce Momjian [Fri, 3 Dec 2004 18:34:31 +0000 (18:34 +0000)]
Back out ARRAY() patch.
Tom Lane [Fri, 3 Dec 2004 17:46:19 +0000 (17:46 +0000)]
Improve description of --disable-rpath workaround for regression test
problems.
Bruce Momjian [Fri, 3 Dec 2004 17:13:28 +0000 (17:13 +0000)]
> If it bothers you that much. I'd make a flag, cleared at the start of
> each COPY, and then where we test for CR or LF in CopyAttributeOutCSV,
> if the flag is not set then set it and issue the warning.
Andrew Dunstan
Bruce Momjian [Fri, 3 Dec 2004 17:12:09 +0000 (17:12 +0000)]
>>This patch adds another plpgsql trigger example to the chapter. It uses
>>the emp table again, but shows how to audit changes into another table
>>(emp_audit).
Mark Kirkwood
Bruce Momjian [Fri, 3 Dec 2004 17:07:50 +0000 (17:07 +0000)]
Add:
> * ANALYZE should record a pg_statistic entry for an all-NULL column
Bruce Momjian [Fri, 3 Dec 2004 06:30:40 +0000 (06:30 +0000)]
Typo fixes.
Bruce Momjian [Fri, 3 Dec 2004 06:18:12 +0000 (06:18 +0000)]
Fix typo.
Bruce Momjian [Fri, 3 Dec 2004 06:04:38 +0000 (06:04 +0000)]
Merge pgadmin paragraph.
Bruce Momjian [Fri, 3 Dec 2004 05:50:18 +0000 (05:50 +0000)]
First version of external projects manual section.
Bruce Momjian [Fri, 3 Dec 2004 02:24:01 +0000 (02:24 +0000)]
Add:
> * Fix priority ordering of read and write light-weight locks (Neil)
Bruce Momjian [Fri, 3 Dec 2004 01:58:43 +0000 (01:58 +0000)]
Fix compile breakage from SIGPIPE fix for threading.
Bruce Momjian [Fri, 3 Dec 2004 01:23:38 +0000 (01:23 +0000)]
Remove doc changes that were in process during previous commit.
Bruce Momjian [Fri, 3 Dec 2004 01:20:33 +0000 (01:20 +0000)]
Back out fix for Unicode characters above 0x10000
Tom Lane [Thu, 2 Dec 2004 23:20:21 +0000 (23:20 +0000)]
Code review for recent libpq changes. Be more careful about error
handling in SIGPIPE processing; avoid unnecessary pollution of application
link-symbol namespace; spell 'pointer to function' in the conventional
way.
Bruce Momjian [Thu, 2 Dec 2004 23:11:30 +0000 (23:11 +0000)]
Add:
<
> o Fix problem with shared memory on the Win32 Terminal Server
Bruce Momjian [Thu, 2 Dec 2004 22:51:28 +0000 (22:51 +0000)]
> I have installed your patch and adjusted the names of the standards
> throughout to the spellings suggested by your book.
Great.
A follow-up patch for current CVS HEAD is attached, and available at
http://troels.arvin.dk/db/pgsql/conformance/pgsql-sql-conformance-
followup.patch
The patch
- includes a core feature ID that had been left
out by mistake (C011)
- updates the sql_feature_packages.txt table to
reflect changes in SQL:2003 which were not
covered properly in my last patch
Troels Arvin
Bruce Momjian [Thu, 2 Dec 2004 22:48:10 +0000 (22:48 +0000)]
> > 8.0beta3 has pg_autovacuum included, when I want to run this as a
> > Windows service, it says you can use the -I and -R options.
> >
> > When I do that and I specify a password with '-P'
> (uppercase) then in
> > the registry it's saved as '-p' (lowercase) in the
> service-commandline
> > (ImagePath).
This was fixed in v1.21 of pg_autovacuum.c, That rev is tagged for
beta3, so you should not be seeing this issue unless you actually have
an older version for some reason.
http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_autovacuum/p
g_autovacuum.c.diff?r1=1.20;r2=1.21;f=h
> > Also it removes the quotes I added and I'm not so sure it
> would work
> > the way it's supposed to, without it.
It's not so much that it strips them (that happens automagically), more
that it doesn't re-add them when it writes the command line in the
registry. The attached patch fixes that by simply quoting all options
that may need it.
> > If you add DependOnService (a REG_MULTI_SZ an
> array-like-thingie) and
> > have the name (in this case: pgsql-8.0-beta2-dev3) of a service it
> > depends on, it will not fail to start (it will not even try, as
> > PostgreSQL is not running), when PostgreSQL already failed.
> >
> > Maybe it's an idea to specify it on the commandline (what
> service to
> > depend on).
A -E <service> option is added in the attached patch.
Dave Page
Bruce Momjian [Thu, 2 Dec 2004 22:40:18 +0000 (22:40 +0000)]
> I enclose a short patch to reduce the PGARCH_RESTART_INTERVAL from 60
> seconds to 10 seconds. The original number was plucked from thin air
> some months ago, and I'd like to review that now based upon further
> thought, observation and experience.
>
> This change has little or no effect on performance, since the interval
> is there mainly to avoid repeated respawn attempts if archiver fails at
> startup. Archiver start-up time is very quick, so there is little danger
> of exceeding 10 seconds.
>
> On a busy system, if the archiver does die, then many files can build up
> in the 60 seconds before respawning. That xlog file backlog could take
> some time to clear. This then leaves a larger than normal window of data
> loss for a possibly long period.
>
> It's a minor change only, with no other effect on function.
Simon Riggs
Bruce Momjian [Thu, 2 Dec 2004 22:37:14 +0000 (22:37 +0000)]
Fix for Unicode characters above 0x10000.
John Hansen
Bruce Momjian [Thu, 2 Dec 2004 22:28:22 +0000 (22:28 +0000)]
On win32, there is currently no way to get the equivalent function of
the "ps" argument list on Unix - meaning that there is no way to
identify for example the stats processors or the bgwriter.
This patch adds this functionality, in a bit of a crufty way. It creates
a kernel Event object with the name of what would be in the title. This
can be viewed using for example Process Explorer.
It's been very handy for me during both debugging and using. I haven't
figured a better way, but perhaps someone has one that's less crufty? If
not, here is at least a working patch :-)
Magnus Hagander
Bruce Momjian [Thu, 2 Dec 2004 22:21:12 +0000 (22:21 +0000)]
Attached is a patch that adds the function xml_encode_special_chars to
the xml2 contrib module. It's against 8.0beta4. It's intended for
commit.
Markus Bertheau <twanger@bluetwanger.de>
Bruce Momjian [Thu, 2 Dec 2004 22:14:38 +0000 (22:14 +0000)]
Add Charset WIN1252 support.
Roland Volkmann
Tom Lane [Thu, 2 Dec 2004 21:41:12 +0000 (21:41 +0000)]
Allow libedit to keep its headers in /usr/include/readline/ ... not a
very good practice IMHO, but apparently some people think so.
Bruce Momjian [Thu, 2 Dec 2004 21:04:47 +0000 (21:04 +0000)]
Add documention on ARRAY() function.
David Fetter
Bruce Momjian [Thu, 2 Dec 2004 20:35:45 +0000 (20:35 +0000)]
Add mention of using --disable-rpath with regression test.
Bruce Momjian [Thu, 2 Dec 2004 20:31:17 +0000 (20:31 +0000)]
Prevent pg_autovacuum -D from needing an argument.
Kenneth Marshall
Tom Lane [Thu, 2 Dec 2004 20:04:20 +0000 (20:04 +0000)]
Hack to work around broken linker on older NetBSD/OpenBSD/Irix assumed
that readline must depend on libcurses, but it seems more recent ones
use libtermcap instead. Allow that case.
Bruce Momjian [Thu, 2 Dec 2004 19:38:50 +0000 (19:38 +0000)]
Change Win32 dlerror message to:
return "dynamic loading error";
Bruce Momjian [Thu, 2 Dec 2004 19:37:58 +0000 (19:37 +0000)]
Add for Win32:
> o Improve dlerror() reporting string
Bruce Momjian [Thu, 2 Dec 2004 19:32:57 +0000 (19:32 +0000)]
Add:
> * Allow a warm standby system to also allow read-only queries
>
> This is useful for checking PITR recovery.
>
Tom Lane [Thu, 2 Dec 2004 19:28:49 +0000 (19:28 +0000)]
Disallow the combination VACUUM FULL FREEZE for safety's sake, for the
reasons I outlined in pghackers a few days ago.
Also, undo someone's overly optimistic decision to reduce tuple state
checks from if (...) elog() to Asserts. If I trusted this code more,
I might think it was a good idea to disable these checks in production
installations. But I don't.
Bruce Momjian [Thu, 2 Dec 2004 18:13:47 +0000 (18:13 +0000)]
Add:
> * Fix psql's display of schema information (Neil)
Bruce Momjian [Thu, 2 Dec 2004 18:11:40 +0000 (18:11 +0000)]
Don't bother adding to cflags/cppflags, just set them because configure
handles that, and make solaris debug use no optimization.
Bruce Momjian [Thu, 2 Dec 2004 17:39:54 +0000 (17:39 +0000)]
Wording improvement.
Bruce Momjian [Thu, 2 Dec 2004 17:14:54 +0000 (17:14 +0000)]
Document that btrim()'s second parameter is optional, and defaults to spaces.
Bruce Momjian [Thu, 2 Dec 2004 15:49:25 +0000 (15:49 +0000)]
Update Brazilian FAQ.
Euler Taveira de Oliveira
Bruce Momjian [Thu, 2 Dec 2004 15:32:54 +0000 (15:32 +0000)]
Rework libpq threaded SIGPIPE handling to avoid interference with
calling applications. This is done by blocking sigpipe in the libpq
thread and using sigpending/sigwait to possibily discard any sigpipe we
generated.
Neil Conway [Thu, 2 Dec 2004 06:14:50 +0000 (06:14 +0000)]
Fix a potential free() of string literal in oid2name, per report from
Michael Fuhr. Along the way, fix a bunch of accesses to uninitialized
memory, add a mystrdup() routine and use it to cleanup some code.
Bruce Momjian [Thu, 2 Dec 2004 04:40:37 +0000 (04:40 +0000)]
Add:
>
> * Allow FOR UPDATE queries to do NOWAIT locks
>
Neil Conway [Thu, 2 Dec 2004 04:12:12 +0000 (04:12 +0000)]
This is a little patch to correct the documentation on CVS. The URL for
downloading CVS at cyclic.com site is long defunct, and I changed the text
to not overtly recommend CVS 1.10, a now fairly old version.
Jon Jensen
Bruce Momjian [Thu, 2 Dec 2004 03:46:47 +0000 (03:46 +0000)]
Update Japanese FAQ.
Jun Kuwamura
Tom Lane [Thu, 2 Dec 2004 02:45:07 +0000 (02:45 +0000)]
Teach regex_fixed_prefix() the correct handling of advanced regex
escapes --- they aren't simply quoted characters. Problem noted by
Antti Salmela. Also fix problem with incorrect handling of multibyte
characters when followed by a quantifier.
Tom Lane [Thu, 2 Dec 2004 01:34:18 +0000 (01:34 +0000)]
Make some adjustments to reduce platform dependencies in plan selection.
In particular, there was a mathematical tie between the two possible
nestloop-with-materialized-inner-scan plans for a join (ie, we computed
the same cost with either input on the inside), resulting in a roundoff
error driven choice, if the relations were both small enough to fit in
sort_mem. Add a small cost factor to ensure we prefer materializing the
smaller input. This changes several regression test plans, but with any
luck we will now have more stability across platforms.