Bruce Momjian [Mon, 1 Nov 2004 19:21:50 +0000 (19:21 +0000)]
That's just the lovely way windows handles a "segfault". Gotta be really
interesting for MS to catch all those dumps...
Anyway. Oops. Seems I ran my regression tests with the old psql, and
just managed to update the backend, when I tested that patch. Turns out
there are codepaths where we'd access the Critical Section before it was
initialized. Attached patch breaks the initializeation off to a separate
part and adds that one to a much earlier position in the program.
Magnus Hagander
Bruce Momjian [Mon, 1 Nov 2004 14:33:10 +0000 (14:33 +0000)]
Update comment to point to proper file.
Dave Cramer [Mon, 1 Nov 2004 13:17:12 +0000 (13:17 +0000)]
fixed bug in segfault REVOKE statement
Neil Conway [Mon, 1 Nov 2004 11:11:13 +0000 (11:11 +0000)]
Trivial fixes for English grammar in contrib/btree_gist and contrib/rtree_gist
documentation.
Bruce Momjian [Mon, 1 Nov 2004 04:46:56 +0000 (04:46 +0000)]
Adjust use of sizeof(EXE).
Bruce Momjian [Mon, 1 Nov 2004 04:25:18 +0000 (04:25 +0000)]
Clarify coding of .exe patch
Bruce Momjian [Mon, 1 Nov 2004 02:22:05 +0000 (02:22 +0000)]
Update:
< * Add a GUC variable to control temporary and TOAST tablespace usage
> * Add a GUC variable to control the tablespace for temporary objects
Bruce Momjian [Mon, 1 Nov 2004 00:28:40 +0000 (00:28 +0000)]
Add:
> * Add a GUC variable to control temporary and TOAST tablespace usage
Tom Lane [Sun, 31 Oct 2004 19:14:16 +0000 (19:14 +0000)]
Use psql -q option instead of 2>/dev/null during first invocation
of psql; this should make it easier to diagnose client-side problems,
such as library version mismatch. Also, consistently use -X option
to avoid problems from weird .psqlrc settings.
Tom Lane [Sat, 30 Oct 2004 23:11:27 +0000 (23:11 +0000)]
Invent a new, more thread-safe version of PQrequestCancel, called PQcancel.
Use this new function in psql. Implement query cancellation in psql for
Windows. Code by Magnus Hagander, documentation and minor editorialization
by Tom Lane.
Tom Lane [Sat, 30 Oct 2004 20:53:06 +0000 (20:53 +0000)]
I found a corner case in which it is possible for RI_FKey_check's call
of HeapTupleSatisfiesItself() to trigger a hint-bit update on the tuple:
if the row was updated or deleted by a subtransaction of my own transaction
that was later rolled back. This cannot occur in pre-8.0 of course, so
the hint-bit patch applied a couple weeks ago is OK for existing releases.
But for 8.0 it seems we had better fix things so that RI_FKey_check can
pass the correct buffer number to HeapTupleSatisfiesItself. Accordingly,
add fields to the TriggerData struct to carry the buffer ID(s) for the
old and new tuple(s). There are other possible solutions but this one
seems cleanest; it will allow other AFTER-trigger functions to safely
do tqual.c calls if they want to. Put new fields at end of struct so
that there is no API breakage.
Tom Lane [Sat, 30 Oct 2004 20:44:43 +0000 (20:44 +0000)]
Change COMMIT back to the old behavior of emitting command tag COMMIT,
not ROLLBACK, for the case of COMMIT outside a transaction block.
Alvaro Herrera
Peter Eisentraut [Sat, 30 Oct 2004 08:23:32 +0000 (08:23 +0000)]
Translation update
Tom Lane [Fri, 29 Oct 2004 22:19:53 +0000 (22:19 +0000)]
Rearrange order of pre-commit operations: must close cursors before doing
ON COMMIT actions. Per bug report from Michael Guerin.
Tom Lane [Fri, 29 Oct 2004 19:40:33 +0000 (19:40 +0000)]
Fix broken example for PREPARE.
Bruce Momjian [Fri, 29 Oct 2004 19:30:02 +0000 (19:30 +0000)]
No need to set errorMessage length --- already set in goto target.
Tom Lane [Fri, 29 Oct 2004 19:18:22 +0000 (19:18 +0000)]
Fix failure to think clearly about encoding conversion errors in COPY.
We can't regurgitate the unconverted string as I first thought, because
the elog.c mechanisms will assume the error message data is in the server
encoding and attempt a reverse conversion. Eventually it might be worth
providing a short-circuit path to support this, but for now the simplest
solution is to abandon trying to report back the line contents after a
conversion failure. Per bug report from Sil Lee, 27-Oct-2004.
Bruce Momjian [Fri, 29 Oct 2004 17:53:13 +0000 (17:53 +0000)]
Set errorMessage length in PQrequestCancel() in all places.
Neil Conway [Fri, 29 Oct 2004 03:17:22 +0000 (03:17 +0000)]
Improvements to the CREATE DATABASE reference page's description of the
TABLESPACE clause.
Neil Conway [Fri, 29 Oct 2004 02:11:18 +0000 (02:11 +0000)]
Minor improvements to the tablespace documentation.
Tom Lane [Fri, 29 Oct 2004 00:16:08 +0000 (00:16 +0000)]
Add DEBUG1-level logging of checkpoint start and end. Also, reduce the
'recycled log files' and 'removed log files' messages from DEBUG1 to
DEBUG2, replacing them with a count of files added/removed/recycled in
the checkpoint end message, as per suggestion from Simon Riggs.
Tom Lane [Thu, 28 Oct 2004 22:31:11 +0000 (22:31 +0000)]
This makes dblink pass its installcheck test on platforms where
snprintf(data, len, %s, NULL) crash.
The code was trying to find a connection by name when it already had an
unnamed connection and did not have a name to search with.
Kris Jurka
Tom Lane [Thu, 28 Oct 2004 22:09:31 +0000 (22:09 +0000)]
Code cleanup in dirmod.c. Andrew Dunstan, some further mods by moi.
Tom Lane [Thu, 28 Oct 2004 18:55:08 +0000 (18:55 +0000)]
Fix to_number for the case of a trailing S.
Karel Zak
Peter Eisentraut [Thu, 28 Oct 2004 09:38:27 +0000 (09:38 +0000)]
Translation update
Peter Eisentraut [Thu, 28 Oct 2004 09:01:06 +0000 (09:01 +0000)]
Translation updates
Peter Eisentraut [Thu, 28 Oct 2004 08:54:09 +0000 (08:54 +0000)]
Translation updates
Neil Conway [Thu, 28 Oct 2004 01:38:41 +0000 (01:38 +0000)]
Use AllocateFile(), FreeFile() and palloc() rather than fopen(), fclose()
and malloc() in pgstat.c, respectively. This simplifies error recovery,
as well as being more consistent with the rest of the backend.
Tom Lane [Thu, 28 Oct 2004 00:39:59 +0000 (00:39 +0000)]
On Windows, force a checkpoint just before dropping a database's physical
files and directories. This ensures that the bgwriter will close any open
file references it is holding for files therein, which is needed for the
rmdir() to succeed. Andrew Dunstan and Tom Lane.
Bruce Momjian [Wed, 27 Oct 2004 19:44:14 +0000 (19:44 +0000)]
Have pg_ctl status always output to stdout, even stopped status, not stderr.
Bruce Momjian [Wed, 27 Oct 2004 19:14:07 +0000 (19:14 +0000)]
Fix Cygwin compile for timezone.
Tom Lane [Wed, 27 Oct 2004 18:09:41 +0000 (18:09 +0000)]
When displaying a Var that is a reference to a column of an unnamed join,
try to display it as a reference to the underlying column instead. This
is a legitimate substitution (it wouldn't be for a named join) and it
fixes some cases where the display would otherwise be ambiguous. Per
example from Sim Zacks.
Bruce Momjian [Wed, 27 Oct 2004 17:17:09 +0000 (17:17 +0000)]
Canonicalize Win32 path coming in from pg_ctl -D, idea from Magnus.
Peter Eisentraut [Wed, 27 Oct 2004 11:52:28 +0000 (11:52 +0000)]
Translation update
Neil Conway [Wed, 27 Oct 2004 11:51:40 +0000 (11:51 +0000)]
Add a missing dependency: the "install" target requires "all" to have
been built before it. Per report from Kris Jurka.
Peter Eisentraut [Wed, 27 Oct 2004 11:44:09 +0000 (11:44 +0000)]
New translation
Peter Eisentraut [Wed, 27 Oct 2004 11:22:18 +0000 (11:22 +0000)]
Translation updates
Peter Eisentraut [Wed, 27 Oct 2004 11:13:29 +0000 (11:13 +0000)]
Translation update
Peter Eisentraut [Wed, 27 Oct 2004 11:09:33 +0000 (11:09 +0000)]
Translation updates
Peter Eisentraut [Wed, 27 Oct 2004 10:22:47 +0000 (10:22 +0000)]
Translation updates
Peter Eisentraut [Wed, 27 Oct 2004 10:13:49 +0000 (10:13 +0000)]
Translation updates
Neil Conway [Wed, 27 Oct 2004 07:26:56 +0000 (07:26 +0000)]
Trivial fix: clarify a comment.
Bruce Momjian [Wed, 27 Oct 2004 02:01:14 +0000 (02:01 +0000)]
Update German FAQ.
Ian Barwick
Bruce Momjian [Tue, 26 Oct 2004 23:42:49 +0000 (23:42 +0000)]
Add reminder to update copyright in sgml file.
Tom Lane [Tue, 26 Oct 2004 22:16:12 +0000 (22:16 +0000)]
Document IS DISTINCT FROM in a more obvious place, and add some more
index entries for IS-foo constructs.
Bruce Momjian [Tue, 26 Oct 2004 19:41:22 +0000 (19:41 +0000)]
Add:
> * Allow TIMESTAMP WITH TIME ZONE to store the original timezone
> information, either by name or offset from UTC
Bruce Momjian [Tue, 26 Oct 2004 17:28:27 +0000 (17:28 +0000)]
Update Russian FAQ.
Viktor Vislobokov
Tom Lane [Tue, 26 Oct 2004 16:05:03 +0000 (16:05 +0000)]
Make heap_fetch API more consistent by having the buffer remain pinned
in all cases when keep_buf = true. This allows ANALYZE's inner loop to
use heap_release_fetch, which saves multiple buffer lookups for the same
page and avoids overestimation of cost by the vacuum cost mechanism.
Tom Lane [Mon, 25 Oct 2004 15:42:02 +0000 (15:42 +0000)]
In the new dispensation where REINDEX doesn't take exclusive lock on
the parent table, it's essential that all index accesses take some kind
of lock on the index. I had missed vacuumlazy.c :-( ...
Neil Conway [Mon, 25 Oct 2004 06:40:39 +0000 (06:40 +0000)]
Update copyright information in documentation. Also, add a note
to RELEASE_CHANGES so that this is not forgotten in the future.
Neil Conway [Mon, 25 Oct 2004 06:27:21 +0000 (06:27 +0000)]
Remove three unnecessary casts from a pointer type to char * when calling
pfree().
Neil Conway [Mon, 25 Oct 2004 03:23:02 +0000 (03:23 +0000)]
Fix tyop in comment.
Tom Lane [Mon, 25 Oct 2004 03:08:29 +0000 (03:08 +0000)]
Make error message more verbose, in hopes of avoiding misunderstandings
such as bug #1293.
Tom Lane [Mon, 25 Oct 2004 02:30:29 +0000 (02:30 +0000)]
Fix some more 'old-style parameter declaration' warnings.
Tom Lane [Mon, 25 Oct 2004 02:15:02 +0000 (02:15 +0000)]
Fix a bunch of 'old-style parameter declaration' warnings induced by
writing 'foo()' rather than 'foo(void)'.
Neil Conway [Mon, 25 Oct 2004 00:46:43 +0000 (00:46 +0000)]
Modify hash_create() to elog(ERROR) if an error occurs, rather than
returning a NULL pointer (some callers remembered to check the return
value, but some did not -- it is safer to just bail out).
Also, cleanup pgstat.c to use elog(ERROR) rather than elog(LOG) followed
by exit().
PostgreSQL Daemon [Mon, 25 Oct 2004 00:11:04 +0000 (00:11 +0000)]
make sure we tag configure.in as beta4 as well ...
Tom Lane [Sun, 24 Oct 2004 22:52:04 +0000 (22:52 +0000)]
Update for 8.0: pg_tablespace is now also a shared catalog.
Tom Lane [Sun, 24 Oct 2004 22:43:56 +0000 (22:43 +0000)]
Add note that REINDEX takes a weaker lock than it used to.
Tom Lane [Sun, 24 Oct 2004 22:11:37 +0000 (22:11 +0000)]
Add comparison file for exp-three-digits formatting.
Tom Lane [Sun, 24 Oct 2004 22:09:33 +0000 (22:09 +0000)]
Adjust message to not be misleading on Windows.
Andrew Dunstan
Tom Lane [Sun, 24 Oct 2004 22:08:19 +0000 (22:08 +0000)]
On Windows, cause get_progname to strip any .EXE suffix.
Andrew Dunstan
Tom Lane [Sun, 24 Oct 2004 21:54:57 +0000 (21:54 +0000)]
Add comparison file for exp-three-digits formatting.
Tom Lane [Sun, 24 Oct 2004 21:47:07 +0000 (21:47 +0000)]
Replace ad-hoc atof() code with call to float4in, per Andrew Dunstan.
Tom Lane [Sun, 24 Oct 2004 15:55:29 +0000 (15:55 +0000)]
Write config files as text not binary, per Magnus Hagander.
Tom Lane [Sun, 24 Oct 2004 15:09:57 +0000 (15:09 +0000)]
Sync timezone data with latest zic database (dated Oct 11 2004).
Tom Lane [Sun, 24 Oct 2004 15:01:54 +0000 (15:01 +0000)]
Update RELEASE_CHANGES to mention updating the timezone database as
a routine part of release prep.
Dennis Bjorklund [Sun, 24 Oct 2004 14:55:04 +0000 (14:55 +0000)]
Translation update
Tom Lane [Sun, 24 Oct 2004 00:54:12 +0000 (00:54 +0000)]
If we're going to test for switch validity by observing whether the
compiler emits any warnings, the test program had better be 100%
correct, not only 90% correct. The recent addition of -Wold-style-definition
broke thread-safety detection on every platform that has that switch,
because the test program used an old-style definition.
Dennis Bjorklund [Sat, 23 Oct 2004 14:48:03 +0000 (14:48 +0000)]
Translation update
Dennis Bjorklund [Sat, 23 Oct 2004 07:29:27 +0000 (07:29 +0000)]
Translation updates
Dennis Bjorklund [Sat, 23 Oct 2004 06:48:59 +0000 (06:48 +0000)]
Translation update
Dennis Bjorklund [Sat, 23 Oct 2004 06:40:24 +0000 (06:40 +0000)]
Translation updates
Dennis Bjorklund [Sat, 23 Oct 2004 06:32:53 +0000 (06:32 +0000)]
Translation updates
Tom Lane [Sat, 23 Oct 2004 00:05:27 +0000 (00:05 +0000)]
Avoid overflow in cost_sort when work_mem exceeds 1Gb.
Tom Lane [Fri, 22 Oct 2004 22:33:58 +0000 (22:33 +0000)]
Fix tsearch build problems.
Magnus Hagander
Tom Lane [Fri, 22 Oct 2004 22:30:57 +0000 (22:30 +0000)]
Don't use LC_MESSAGES value on WIN32, since it doesn't work.
Magnus Hagander
Tom Lane [Fri, 22 Oct 2004 19:48:19 +0000 (19:48 +0000)]
Add a GUC_SUPERUSER_ONLY flag to mark GUC variables that should not be
examinable by non-superusers, and use it to protect the recently-added
GUC variables for data directory and config files. For now I have only
flagged those variables that could be used to deduce something about
the server's filesystem layout, but possibly we should also mark vars
related to logging settings and other admin-only information?
Tom Lane [Fri, 22 Oct 2004 17:20:05 +0000 (17:20 +0000)]
In ALTER COLUMN TYPE, strip any implicit coercion operations appearing
at the top level of the column's old default expression before adding
an implicit coercion to the new column type. This seems to satisfy the
principle of least surprise, as per discussion of bug #1290.
Peter Eisentraut [Fri, 22 Oct 2004 16:05:02 +0000 (16:05 +0000)]
Translation updates
Peter Eisentraut [Fri, 22 Oct 2004 16:04:35 +0000 (16:04 +0000)]
Message styling
Dennis Bjorklund [Fri, 22 Oct 2004 14:14:24 +0000 (14:14 +0000)]
Translation update
Dennis Bjorklund [Fri, 22 Oct 2004 14:13:04 +0000 (14:13 +0000)]
New swedish translation of pg_config
Neil Conway [Fri, 22 Oct 2004 14:12:41 +0000 (14:12 +0000)]
Fix documentation typo.
Dennis Bjorklund [Fri, 22 Oct 2004 13:49:15 +0000 (13:49 +0000)]
Translation updates
Dennis Bjorklund [Fri, 22 Oct 2004 13:41:47 +0000 (13:41 +0000)]
Translation updates
Dennis Bjorklund [Fri, 22 Oct 2004 12:04:13 +0000 (12:04 +0000)]
Translation updates.
Neil Conway [Fri, 22 Oct 2004 07:21:06 +0000 (07:21 +0000)]
Minor code cleanup: hdefault() only ever returned "true", so it may as
well be declared to return "void" to save callers the trouble of
checking for errors.
Tom Lane [Fri, 22 Oct 2004 00:25:18 +0000 (00:25 +0000)]
Update release history for releases 7.4.6, 7.3.8, 7.2.6.
Tom Lane [Fri, 22 Oct 2004 00:24:18 +0000 (00:24 +0000)]
Prevent pg_ctl from being run as root. Since it uses configuration files
owned by postgres, doing "pg_ctl start" as root could allow a privilege
escalation attack, as pointed out by iDEFENSE. Of course the postmaster would
fail, but we ought to fail a little sooner to protect sysadmins unfamiliar
with Postgres. The chosen fix is to disable root use of pg_ctl in all cases,
just to be confident there are no other holes.
Tom Lane [Thu, 21 Oct 2004 22:48:54 +0000 (22:48 +0000)]
Update obsolete comments about COPY vs INSERT options, per Uwe Schroeder.
Tom Lane [Thu, 21 Oct 2004 21:33:59 +0000 (21:33 +0000)]
Disallow referential integrity actions from being deferred; only the
NO ACTION check is deferrable. This seems to be a closer approximation
to what the SQL spec says than what we were doing before, and it prevents
some anomalous behaviors that are possible now that triggers can fire
during the execution of PL functions.
Stephan Szabo.
Tom Lane [Thu, 21 Oct 2004 20:23:19 +0000 (20:23 +0000)]
Set the close-on-exec flag for libpq's socket to the backend, to avoid
any possible problems from child programs executed by the client app.
Per suggestion from Elliot Lee of Red Hat.
Tom Lane [Thu, 21 Oct 2004 19:49:27 +0000 (19:49 +0000)]
Avoid macro-redefinition warnings on Windows, per Andrew Dunstan.
Tom Lane [Thu, 21 Oct 2004 19:28:36 +0000 (19:28 +0000)]
Standardize on using the Min, Max, and Abs macros that are in our c.h file,
getting rid of numerous ad-hoc versions that have popped up in various
places. Shortens code and avoids conflict with Windows min() and max()
macros.
Tom Lane [Wed, 20 Oct 2004 16:42:46 +0000 (16:42 +0000)]
Use temp files in current directory, not /tmp, to reduce security risk
while running this script.
Tom Lane [Wed, 20 Oct 2004 16:04:50 +0000 (16:04 +0000)]
Allow functions returning void or cstring to appear in FROM clause,
to make life cushy for the JDBC driver. Centralize the decision-making
that affects this by inventing a get_type_func_class() function, rather
than adding special cases in half a dozen places.
Neil Conway [Wed, 20 Oct 2004 02:12:07 +0000 (02:12 +0000)]
When using GCC, change the default CFLAGS to:
-O2 -Wall -Wmissing-prototypes -Wpointer-arith
Check whether the version of GCC we are using supports any of:
-Wdeclaration-after-statement
-Wendif-labels
-Wold-style-definition
And add the supported flags to CFLAGS.
Tom Lane [Tue, 19 Oct 2004 15:04:17 +0000 (15:04 +0000)]
Add a HINT about the likely reason for 'invalid multibyte character for locale' failure.
Peter Eisentraut [Tue, 19 Oct 2004 13:39:27 +0000 (13:39 +0000)]
New translation