Tom Lane [Sat, 27 Feb 2010 21:53:21 +0000 (21:53 +0000)]
Insert a hack into get_float8_nan (both core and ecpg copies) to deal with
the fact that NetBSD/mips is currently broken, as per buildfarm member pika.
Also add regression tests to ensure that get_float8_nan and get_float4_nan
are exercised even on platforms where they are not needed by
float8in/float4in.
Zoltán Böszörményi and Tom Lane
Bruce Momjian [Sat, 27 Feb 2010 20:20:44 +0000 (20:20 +0000)]
Back out unintended change to pg_locale.c.
Bruce Momjian [Sat, 27 Feb 2010 20:16:17 +0000 (20:16 +0000)]
Document ATAPI FLUSH CACHE EXT.
Bruce Momjian [Sat, 27 Feb 2010 14:46:05 +0000 (14:46 +0000)]
Document trace_recovery_messages() parameter as an enum, not string.
Fujii Masao
Heikki Linnakangas [Sat, 27 Feb 2010 09:29:20 +0000 (09:29 +0000)]
Document max_standby_delay=-1 option, now that it's allowed again.
Tom Lane [Sat, 27 Feb 2010 04:29:44 +0000 (04:29 +0000)]
Entity-ify a few new uses of literal <, >, and &.
Tom Lane [Sat, 27 Feb 2010 03:55:52 +0000 (03:55 +0000)]
Undo some more pgindent breakage. Per buildfarm.
Bruce Momjian [Sat, 27 Feb 2010 03:41:34 +0000 (03:41 +0000)]
Use <> for libpq #include in example programs, per suggestion from Josh Berkus.
Bruce Momjian [Sat, 27 Feb 2010 01:39:46 +0000 (01:39 +0000)]
Document ATAPI drive flush command, and mention SSD drives.
Bruce Momjian [Fri, 26 Feb 2010 18:00:15 +0000 (18:00 +0000)]
Suggest gmake installcheck-world for pgindent testing.
Bruce Momjian [Fri, 26 Feb 2010 17:07:55 +0000 (17:07 +0000)]
Revert pgindent changes to ecpg include files that are part of ecpg
regession test output, and update pgindent script to avoid them in the
future.
Bruce Momjian [Fri, 26 Feb 2010 15:57:34 +0000 (15:57 +0000)]
Wording improvements to README.
Bruce Momjian [Fri, 26 Feb 2010 15:42:36 +0000 (15:42 +0000)]
Update pgindent docs to use maintainer-clean.
Bruce Momjian [Fri, 26 Feb 2010 13:50:34 +0000 (13:50 +0000)]
Document why pgindent wants a fresh CVS checkout.
Bruce Momjian [Fri, 26 Feb 2010 04:14:36 +0000 (04:14 +0000)]
In vacuumdb --help, call analyze "statistics", not "hints".
Bruce Momjian [Fri, 26 Feb 2010 02:58:49 +0000 (02:58 +0000)]
Call output file typedefs.list; update README.
Bruce Momjian [Fri, 26 Feb 2010 02:31:52 +0000 (02:31 +0000)]
Document pg_restore --jobs as a performance enhancement.
Bruce Momjian [Fri, 26 Feb 2010 02:11:52 +0000 (02:11 +0000)]
Update pgindent instructions.
Bruce Momjian [Fri, 26 Feb 2010 02:01:40 +0000 (02:01 +0000)]
pgindent run for 9.0
Bruce Momjian [Fri, 26 Feb 2010 01:55:35 +0000 (01:55 +0000)]
Add pgindent typedefs file to CVS.
Bruce Momjian [Fri, 26 Feb 2010 01:40:15 +0000 (01:40 +0000)]
Update pgindent instructions to avoid changes to flex output files.
Bruce Momjian [Fri, 26 Feb 2010 01:11:46 +0000 (01:11 +0000)]
Remove 'emphasis' markup inside literal; not allowed.
Bruce Momjian [Thu, 25 Feb 2010 22:24:00 +0000 (22:24 +0000)]
Document that after triggers that need to see changed rows should not be
marked stable.
Tom Lane [Thu, 25 Feb 2010 20:59:53 +0000 (20:59 +0000)]
Allow predicate_refuted_by() to deduce that NOT A refutes A.
We had originally made the stronger assumption that NOT A refutes any B
if B implies A, but this fails in three-valued logic, because we need to
prove B is false not just that it's not true. However the logic does
go through if B is equal to A.
Recognizing this limited case is enough to handle examples that arise when
we have simplified "bool_var = true" or "bool_var = false" to just "bool_var"
or "NOT bool_var". If we had not done that simplification then the
btree-operator proof logic would have been able to prove that the expressions
were contradictory, but only for identical expressions being compared to the
constants; so handling identical A and B covers all the same cases.
The motivation for doing this is to avoid unexpected asymmetrical behavior
when a partitioned table uses a boolean partitioning column, as in today's
gripe from Dominik Sander.
Back-patch to 8.2, which is as far back as predicate_refuted_by attempts to
do anything at all with NOTs.
Bruce Momjian [Thu, 25 Feb 2010 19:20:38 +0000 (19:20 +0000)]
Document clearly the meaning of none/all for log_statements.
Bruce Momjian [Thu, 25 Feb 2010 18:36:14 +0000 (18:36 +0000)]
Add C comment that do_to_timestamp() lacks error checking.
Bruce Momjian [Thu, 25 Feb 2010 18:16:53 +0000 (18:16 +0000)]
Clearly document that timestamp alone means timestamp without timezone,
per SQL standard, and mention 7.3 behavior at the end.
Magnus Hagander [Thu, 25 Feb 2010 13:26:16 +0000 (13:26 +0000)]
Add configuration parameter ssl_renegotiation_limit to control
how often we do SSL session key renegotiation. Can be set to
0 to disable renegotiation completely, which is required if
a broken SSL library is used (broken patches to CVE-2009-3555
a known cause) or when using a client library that can't do
renegotiation.
Magnus Hagander [Thu, 25 Feb 2010 10:02:30 +0000 (10:02 +0000)]
Fix typos, per Richard Huxton
Heikki Linnakangas [Thu, 25 Feb 2010 09:32:19 +0000 (09:32 +0000)]
Clarify that the connection string for primary_conninfo is in the same
format as in PQconnectdb(). As pointed out by Thom Brown.
Heikki Linnakangas [Thu, 25 Feb 2010 09:16:42 +0000 (09:16 +0000)]
Fix typo.
Heikki Linnakangas [Thu, 25 Feb 2010 08:57:47 +0000 (08:57 +0000)]
Small streaming replication document improvements. Be more explicit that
it's asynchronous.
Heikki Linnakangas [Thu, 25 Feb 2010 07:31:40 +0000 (07:31 +0000)]
Fix streaming replication starting at the very first WAL segment.
Per complaint from Greg Stark.
Tom Lane [Thu, 25 Feb 2010 03:08:07 +0000 (03:08 +0000)]
Improve warning about creating nested named subroutines in plperl.
Per discussion.
Tom Lane [Thu, 25 Feb 2010 02:17:50 +0000 (02:17 +0000)]
Make pg_stop_backup's reporting a bit more verbose in hopes of making
error cases less intimidating for novices. Per discussion.
Greg Smith
Tom Lane [Wed, 24 Feb 2010 18:02:24 +0000 (18:02 +0000)]
Allow zero-dimensional (ie, empty) arrays in contrib/ltree operations.
The main motivation for changing this is bug #4921, in which it's pointed out
that it's no longer safe to apply ltree operations to the result of
ARRAY(SELECT ...) if the sub-select might return no rows. Before 8.3,
the ARRAY() construct would return NULL, which might or might not be helpful
but at least it wouldn't result in an error. Now it returns an empty array
which results in a failure for no good reason, since the ltree operations
are all perfectly capable of dealing with zero-element arrays.
As far as I can find, these ltree functions are the only places where zero
array dimensionality is rejected unnecessarily.
Back-patch to 8.3 to prevent behavioral regression of queries that worked
in older releases.
Bruce Momjian [Wed, 24 Feb 2010 16:27:40 +0000 (16:27 +0000)]
Document that pg_restore -t can use -n for its schema qualification.
Bruce Momjian [Wed, 24 Feb 2010 15:54:31 +0000 (15:54 +0000)]
Revert removal of pre-7.4 documenation behavior mentions.
Alvaro Herrera [Wed, 24 Feb 2010 14:10:24 +0000 (14:10 +0000)]
Remove stray semicolon, per report from strk
Itagaki Takahiro [Wed, 24 Feb 2010 05:20:49 +0000 (05:20 +0000)]
Remove useless codes to initialize TupleDesc from dblink_exec.
Bruce Momjian [Wed, 24 Feb 2010 03:33:49 +0000 (03:33 +0000)]
Remove pre-7.4 documentaiton mentions, now that 8.0 is the oldest
supported release.
Tom Lane [Wed, 24 Feb 2010 02:42:55 +0000 (02:42 +0000)]
Fix patch for printing backend and pg_dump versions so that it works in
a desirable fashion in archive-dump cases, ie you should get the pg_dump
version not the pg_restore version.
Tom Lane [Wed, 24 Feb 2010 02:15:58 +0000 (02:15 +0000)]
Un-break pg_dump for the case of zero-column tables.
This was evidently broken by the CREATE TABLE OF TYPE patch. It would have
been noticed if anyone had bothered to try dumping and restoring the
regression database ...
Tom Lane [Wed, 24 Feb 2010 01:57:16 +0000 (01:57 +0000)]
Use CREATE OR REPLACE LANGUAGE in pg_dump to avoid the need for a couple of
significantly uglier kluges that were working around the change in plpgsql's
preinstalled status.
Tom Lane [Wed, 24 Feb 2010 01:35:14 +0000 (01:35 +0000)]
Make pg_regress use CREATE OR REPLACE LANGUAGE, so that --load-language
will work whether or not the specified language is preinstalled. This
responds to some complaints about having to change test scripts because
plpgsql is preinstalled as of 9.0.
Tom Lane [Tue, 23 Feb 2010 22:51:43 +0000 (22:51 +0000)]
Add an OR REPLACE option to CREATE LANGUAGE.
This operates in the same way as other CREATE OR REPLACE commands, ie,
it replaces everything but the ownership and ACL lists of an existing
entry, and requires the caller to have owner privileges for that entry.
While modifying an existing language has some use in development scenarios,
in typical usage all the "replaced" values come from pg_pltemplate so there
will be no actual change in the language definition. The reason for adding
this is mainly to allow programs to ensure that a language exists without
triggering an error if it already does exist.
This commit just adds and documents the new option. A followon patch
will use it to clean up some unpleasant cases in pg_dump and pg_regress.
Bruce Momjian [Tue, 23 Feb 2010 22:17:25 +0000 (22:17 +0000)]
Modify freebsd start script to just exit 0 with message.
Bruce Momjian [Tue, 23 Feb 2010 22:15:35 +0000 (22:15 +0000)]
Update startup scripts for Linux and FreeBSD.
Kevin Grittner
Bruce Momjian [Tue, 23 Feb 2010 21:48:32 +0000 (21:48 +0000)]
Have pg_dump (-v) verbose mode output the pg_dump and server versions in
text output mode, like we do in custom output mode.
Jim Cox
Bruce Momjian [Tue, 23 Feb 2010 21:38:35 +0000 (21:38 +0000)]
Revert recent COPY manual change about encoding; add mention of "server".
Tom Lane [Tue, 23 Feb 2010 18:35:07 +0000 (18:35 +0000)]
Fix configure's regexp for extracting the Perl version number from perl -v
output. Per bug #5339, Perl 5.11 has changed the format of that output
enough to break the previous coding.
Alex Hunsaker
Tom Lane [Tue, 23 Feb 2010 17:28:09 +0000 (17:28 +0000)]
Clarify statements about tar archive format.
Tom Lane [Tue, 23 Feb 2010 16:55:22 +0000 (16:55 +0000)]
Minor style policing for error messages in pg_dump tar code. Notably, change
"dumping data out of order is not supported" to "restoring data out of order
is not supported", because you get that error during pg_restore not pg_dump.
Also fix some comments that didn't look so good after being pgindented as
perhaps they did originally.
Bruce Momjian [Tue, 23 Feb 2010 16:14:26 +0000 (16:14 +0000)]
Revert recent change of to_char('HH12') handling for intervals; instead
improve documentation, and add C comment.
Bruce Momjian [Tue, 23 Feb 2010 06:29:01 +0000 (06:29 +0000)]
Secondary patch to fix interval to_char() for "HH" where hours >= 12.
Tom Lane [Tue, 23 Feb 2010 05:44:55 +0000 (05:44 +0000)]
Some platforms reject fsync() on files opened O_RDONLY.
Bruce Momjian [Tue, 23 Feb 2010 05:17:33 +0000 (05:17 +0000)]
Make documentation more direct about the handling of COPY files based on
the client encoding.
Bruce Momjian [Tue, 23 Feb 2010 02:47:27 +0000 (02:47 +0000)]
Document that expression indexes that call functions allow function-level
statistics.
Bruce Momjian [Tue, 23 Feb 2010 01:42:19 +0000 (01:42 +0000)]
Supress convertion of zero hours to '12' for intervals when using
to_char with HH, e.g.
to_char(interval '0d 0h 12m 44s', 'DD HH24 MI SS');
now returns:
00 00 12 44
not:
00 12 12 44
Bruce Momjian [Tue, 23 Feb 2010 00:21:19 +0000 (00:21 +0000)]
Update pg_restore documentation to show new pg_restore custom listing
format.
Pavel Golub
Bruce Momjian [Mon, 22 Feb 2010 23:51:40 +0000 (23:51 +0000)]
Remove long-commented-out paragraph in documentation about function
inheritance in create table, per Andrew Dunstan.
Bruce Momjian [Mon, 22 Feb 2010 22:30:10 +0000 (22:30 +0000)]
Document that pg_ctl cares about the PGHOST environment variable.
Bruce Momjian [Mon, 22 Feb 2010 21:16:50 +0000 (21:16 +0000)]
Revert configure warning to use "official distribution".
Bruce Momjian [Mon, 22 Feb 2010 18:12:04 +0000 (18:12 +0000)]
Remove protocol documentation paragraph about environment variable
passing being "covered elsewhere", per Dave Page.
Bruce Momjian [Mon, 22 Feb 2010 18:02:06 +0000 (18:02 +0000)]
Use the term "bundled distribution" instead of "official distribution" in
configure warnings.
Bruce Momjian [Mon, 22 Feb 2010 17:15:10 +0000 (17:15 +0000)]
Briefly document in two places that pg_dump and pg_dumpall cannot be
used for continuous archiving.
Tom Lane [Mon, 22 Feb 2010 15:29:46 +0000 (15:29 +0000)]
Let's try forcing errno to zero before issuing fsync. The current buildfarm
results claiming EBADF seem improbable enough that I'm not convinced fsync
is really returning that --- could it be failing to set errno at all?
Tom Lane [Mon, 22 Feb 2010 15:26:14 +0000 (15:26 +0000)]
Adjust pg_fsync_writethrough so that it will set errno when failing
on a platform that doesn't support this operation. The former coding
would allow an unrelated errno to be reported, which would be quite
misleading. Not sure if this has anything to do with the current
buildfarm failures, but it's certainly bogus as-is.
Heikki Linnakangas [Mon, 22 Feb 2010 11:47:30 +0000 (11:47 +0000)]
Move documentation of all recovery.conf option to a new chapter.
They used to be scattered between the "backup and restore" and "streaming
replication" chapters.
Tom Lane [Mon, 22 Feb 2010 02:50:10 +0000 (02:50 +0000)]
Fix multiple copy and paste-o's. No wonder this code didn't work.
Greg Stark [Mon, 22 Feb 2010 00:11:05 +0000 (00:11 +0000)]
Oops, don't forget to rewind the directory before scanning it to fsync files in CREATE DATABASE
Andrew Dunstan [Sat, 20 Feb 2010 22:24:29 +0000 (22:24 +0000)]
Adjust sample auto-explain output to reflect query text inclusion.
Tom Lane [Sat, 20 Feb 2010 21:24:02 +0000 (21:24 +0000)]
Clean up handling of XactReadOnly and RecoveryInProgress checks.
Add some checks that seem logically necessary, in particular let's make
real sure that HS slave sessions cannot create temp tables. (If they did
they would think that temp tables belonging to the master's session with
the same BackendId were theirs. We *must* not allow myTempNamespace to
become set in a slave session.)
Change setval() and nextval() so that they are only allowed on temp sequences
in a read-only transaction. This seems consistent with what we allow for
table modifications in read-only transactions. Since an HS slave can't have a
temp sequence, this also provides a nicer cure for the setval PANIC reported
by Erik Rijkers.
Make the error messages more uniform, and have them mention the specific
command being complained of. This seems worth the trifling amount of extra
code, since people are likely to see such messages a lot more than before.
Bruce Momjian [Sat, 20 Feb 2010 21:04:28 +0000 (21:04 +0000)]
Make 'include_realm' ordering consistent in the docs, to match recent
doc change.
Bruce Momjian [Sat, 20 Feb 2010 19:21:14 +0000 (19:21 +0000)]
Clarify documentation about username mapping when authenticating with
GSSAPI or Kerberos.
Ian Turner
Bruce Momjian [Sat, 20 Feb 2010 18:28:37 +0000 (18:28 +0000)]
Document that many solid-state drives have volatile write-back caches.
Simon Riggs [Sat, 20 Feb 2010 10:07:27 +0000 (10:07 +0000)]
Copy editing of Hot Standby docs. Some clarifications, addition
of missing items and minor edits.
Tom Lane [Fri, 19 Feb 2010 21:49:10 +0000 (21:49 +0000)]
Reduce the rescan cost estimate for Materialize nodes to cpu_operator_cost per
tuple, instead of the former cpu_tuple_cost. It is sane to charge less than
cpu_tuple_cost because Materialize never does any qual-checking or projection,
so it's got less overhead than most plan node types. In particular, we want
to have the same charge here as is charged for readout in cost_sort. That
avoids the problem recently exhibited by Teodor wherein the planner prefers
a useless sort over a materialize step in a context where a lot of rescanning
will happen. The rescan costs should be just about the same for both node
types, so make their estimates the same.
Not back-patching because all of the current logic for rescan cost estimates
is new in 9.0. The old handling of rescans is sufficiently not-sane that
changing this in that structure is a bit pointless, and might indeed cause
regressions.
Peter Eisentraut [Fri, 19 Feb 2010 18:42:30 +0000 (18:42 +0000)]
Revert version stamping in wrong branch
Peter Eisentraut [Fri, 19 Feb 2010 16:03:22 +0000 (16:03 +0000)]
Version stamp 9.0alpha4
Bruce Momjian [Fri, 19 Feb 2010 14:36:45 +0000 (14:36 +0000)]
Document --version and --help options for all client applications (they
all support it).
Per report from Josh Kupershmidt
Peter Eisentraut [Fri, 19 Feb 2010 14:12:19 +0000 (14:12 +0000)]
Small corrections to message output targets in pg_ctl
- The message "server stopped" should be affected by the -s option, just
like "server started" already was.
- The message "could not start server" should consistently go to stderr.
Heikki Linnakangas [Fri, 19 Feb 2010 10:51:04 +0000 (10:51 +0000)]
Don't use O_DIRECT when writing WAL files if archiving or streaming is
enabled. Bypassing the kernel cache is counter-productive in that case,
because the archiver/walsender process will read from the WAL file
soon after it's written, and if it's not cached the read will cause
a physical read, eating I/O bandwidth available on the WAL drive.
Also, walreceiver process does unaligned writes, so disable O_DIRECT
in walreceiver process for that reason too.
Heikki Linnakangas [Fri, 19 Feb 2010 06:29:19 +0000 (06:29 +0000)]
Forbid setval() during recovery. This prevents the PANIC reported by
Erik Rijkers. Patch by Andres Freund.
Bruce Momjian [Fri, 19 Feb 2010 03:50:03 +0000 (03:50 +0000)]
First pass over client applications documentation proofreading.
gabrielle
Bruce Momjian [Fri, 19 Feb 2010 01:15:54 +0000 (01:15 +0000)]
Remove mention that binary distributions pre-compile the tutorial files.
Itagaki Takahiro [Fri, 19 Feb 2010 01:04:03 +0000 (01:04 +0000)]
Fix STOP WAL LOCATION in backup history files no to return the next
segment of XLOG_BACKUP_END record even if the the record is placed
at a segment boundary. Furthermore the previous implementation could
return nonexistent segment file name when the boundary is in segments
that has "FE" suffix; We never use segments with "FF" suffix.
Backpatch to 8.0, where hot backup was introduced.
Reported by Fujii Masao.
Peter Eisentraut [Fri, 19 Feb 2010 00:40:05 +0000 (00:40 +0000)]
Translation updates for 9.0alpha4
Peter Eisentraut [Fri, 19 Feb 2010 00:35:18 +0000 (00:35 +0000)]
Preliminary release notes for 9.0alpha4
Bruce Momjian [Fri, 19 Feb 2010 00:15:25 +0000 (00:15 +0000)]
Hot Standby documentation updates
Greg Smith
Tom Lane [Thu, 18 Feb 2010 23:50:06 +0000 (23:50 +0000)]
Volatile-ize all five places where we expect a PG_TRY block to restore
old memory context in plpython. Before only one of them was marked
volatile, but per report from Zdenek Kotala, some compilers do the
wrong thing here.
Tom Lane [Thu, 18 Feb 2010 22:43:31 +0000 (22:43 +0000)]
Provide some rather hokey ways for EXPLAIN to print FieldStore and assignment
ArrayRef expressions that are not in the immediate context of an INSERT or
UPDATE targetlist. Such cases never arise in stored rules, so ruleutils.c
hadn't tried to handle them. However, they do occur in the targetlists of
plans derived from such statements, and now that EXPLAIN VERBOSE tries to
print targetlists, we need some way to deal with the case.
I chose to represent an assignment ArrayRef as "array[subscripts] := source",
which is fairly reasonable and doesn't omit any information. However,
FieldStore is problematic because the planner will fold multiple assignments
to fields of the same composite column into one FieldStore, resulting in a
structure that is hard to understand at all, let alone display comprehensibly.
So in that case I punted and just made it print the source expression(s).
Backpatch to 8.4 --- the lack of functionality exists in older releases,
but doesn't seem to be important for lack of anything that would call it.
Tom Lane [Thu, 18 Feb 2010 18:41:47 +0000 (18:41 +0000)]
Fix ExecEvalArrayRef to pass down the old value of the array element or slice
being assigned to, in case the expression to be assigned is a FieldStore that
would need to modify that value. The need for this was foreseen some time
ago, but not implemented then because we did not have arrays of composites.
Now we do, but the point evidently got overlooked in that patch. Net result
is that updating a field of an array element doesn't work right, as
illustrated if you try the new regression test on an unpatched backend.
Noted while experimenting with EXPLAIN VERBOSE, which has also got some issues
in this area.
Backpatch to 8.3, where arrays of composites were introduced.
Heikki Linnakangas [Thu, 18 Feb 2010 11:13:46 +0000 (11:13 +0000)]
Fix pq_getbyte_if_available() function. It was confused on what it
returns if no data is immediately available. Patch by me with numerous
fixes from Fujii Masao and Magnus Hagander.
Itagaki Takahiro [Thu, 18 Feb 2010 04:31:16 +0000 (04:31 +0000)]
date_recv should accept infinities.
Reported by James William Pye.
Bruce Momjian [Thu, 18 Feb 2010 04:14:38 +0000 (04:14 +0000)]
Add missing close tag.
Bruce Momjian [Thu, 18 Feb 2010 03:16:09 +0000 (03:16 +0000)]
Wordsmithing of HS and SR documentation, with some wording improvements
from Erik Rijkers too.
Tom Lane [Thu, 18 Feb 2010 03:06:46 +0000 (03:06 +0000)]
Force READY portals into FAILED state when a transaction or subtransaction
is aborted, if they were created within the failed xact. This prevents
ExecutorEnd from being run on them, which is a good idea because they may
contain references to tables or other objects that no longer exist.
In particular this is hazardous when auto_explain is active, but it's
really rather surprising that nobody has seen an issue with this before.
I'm back-patching this to 8.4, since that's the first version that contains
auto_explain or an ExecutorEnd hook, but I wonder whether we shouldn't
back-patch further.
Tom Lane [Thu, 18 Feb 2010 01:29:10 +0000 (01:29 +0000)]
Fix up pg_dump's treatment of large object ownership and ACLs. We now emit
a separate archive entry for each BLOB, and use pg_dump's standard methods
for dealing with its ownership, ACL if any, and comment if any. This means
that switches like --no-owner and --no-privileges do what they're supposed
to. Preliminary testing says that performance is still reasonable even
with many blobs, though we'll have to see how that shakes out in the field.
KaiGai Kohei, revised by me
Tom Lane [Wed, 17 Feb 2010 16:54:06 +0000 (16:54 +0000)]
Take care to reprocess an uncommitted notify message.
Oversight in my changes to cope with possible errors during message
processing; spotted by Joachim Wieland.