Michael Meskes [Mon, 10 May 2004 13:46:06 +0000 (13:46 +0000)]
- Argh, just another bug in adjust_informix.
- Added "extern C" flags for C++ compiler. Hopefully I got that one right.
Bruce Momjian [Mon, 10 May 2004 03:58:19 +0000 (03:58 +0000)]
Add:
> * Add MERGE command that does UPDATE, or on failure, INSERT
Tom Lane [Sat, 8 May 2004 22:46:29 +0000 (22:46 +0000)]
Fix a couple of oversights in new ALTER TABLE code that broke
ALTER SET STATISTICS for functional indexes.
Tom Lane [Sat, 8 May 2004 21:21:18 +0000 (21:21 +0000)]
Alter string format used for integer and OID lists in stored rules.
This simplifies and speeds up the reader by letting it get the representation
right the first time, rather than correcting it after-the-fact. Also,
after int and OID lists become separate node types per Neil's pending
patch, this will let us treat these lists as just plain Nodes instead
of requiring separate read/write macros the way we have now.
Tom Lane [Sat, 8 May 2004 19:09:25 +0000 (19:09 +0000)]
Get rid of rd_nblocks field in relcache entries. Turns out this was
costing us lots more to maintain than it was worth. On shared tables
it was of exactly zero benefit because we couldn't trust it to be
up to date. On temp tables it sometimes saved an lseek, but not often
enough to be worth getting excited about. And the real problem was that
we forced an lseek on every relcache flush in order to update the field.
So all in all it seems best to lose the complexity.
Bruce Momjian [Sat, 8 May 2004 02:13:31 +0000 (02:13 +0000)]
Fix typo.
Bruce Momjian [Sat, 8 May 2004 02:11:46 +0000 (02:11 +0000)]
Improve style of new log_statement_stats error message, per Peter.
Tom Lane [Sat, 8 May 2004 00:34:49 +0000 (00:34 +0000)]
Get rid of cluster.c's apparatus for rebuilding a relation's indexes
in favor of using the REINDEX TABLE apparatus, which does the same thing
simpler and faster. Also, make TRUNCATE not use cluster.c at all, but
just assign a new relfilenode and REINDEX. This partially addresses
Hartmut Raschick's complaint from last December that 7.4's TRUNCATE is
an order of magnitude slower than prior releases. By getting rid of
a lot of unnecessary catalog updates, these changes buy back about a
factor of two (on my system). The remaining overhead seems associated
with creating and deleting storage files, which we may not be able to
do much about without abandoning transaction safety for TRUNCATE.
Neil Conway [Fri, 7 May 2004 19:12:26 +0000 (19:12 +0000)]
Refactor CheckDropPermissions() to move some initialization code for
printing the proper error message out of the common path.
Tom Lane [Fri, 7 May 2004 16:57:16 +0000 (16:57 +0000)]
The timezone() family of functions (a/k/a AT TIME ZONE construct) can
safely be marked immutable, since their results don't depend on the
TimeZone GUC variable. Per recent discussion.
Michael Meskes [Fri, 7 May 2004 13:42:49 +0000 (13:42 +0000)]
- Added additional test case.
- Fixed bug that reversed string length in typedefs.
- Added portability file to pgtypeslib.
Tom Lane [Fri, 7 May 2004 13:09:12 +0000 (13:09 +0000)]
Suppress 'uninitialized variable' warning emitted by some (not all)
versions of gcc. The code is correct AFAICS, but it requires slightly
more analysis than usual to see that the variable can't be used uninitialized.
Teodor Sigaev [Fri, 7 May 2004 11:19:06 +0000 (11:19 +0000)]
Use regprocedure type instead of oid. Usefull for human read and dump/restore
Tom Lane [Fri, 7 May 2004 03:19:44 +0000 (03:19 +0000)]
NATURAL CROSS JOIN is a contradiction in terms, not to mention disallowed
by the SQL spec and by our parser. Thanks to Jonathan Scott for finding
this longstanding error.
Bruce Momjian [Fri, 7 May 2004 02:40:43 +0000 (02:40 +0000)]
Uppercase keyword for ecpg.
Bruce Momjian [Fri, 7 May 2004 01:53:41 +0000 (01:53 +0000)]
Remove crude test for log_statement_stats in startup code now that we
have a more proper GUC based test.
Also change error return code to ERRCODE_INVALID_PARAMETER_VALUE so it
matches the old error return code.
Bruce Momjian [Fri, 7 May 2004 01:34:08 +0000 (01:34 +0000)]
Throw error if log_statement_stats is used with confliction options for
per-query stage stats.
Tom Lane [Fri, 7 May 2004 00:24:59 +0000 (00:24 +0000)]
Solve the 'Turkish problem' with undesirable locale behavior for case
conversion of basic ASCII letters. Remove all uses of strcasecmp and
strncasecmp in favor of new functions pg_strcasecmp and pg_strncasecmp;
remove most but not all direct uses of toupper and tolower in favor of
pg_toupper and pg_tolower. These functions use the same notions of
case folding already developed for identifier case conversion. I left
the straight locale-based folding in place for situations where we are
just manipulating user data and not trying to match it to built-in
strings --- for example, the SQL upper() function is still locale
dependent. Perhaps this will prove not to be what's wanted, but at
the moment we can initdb and pass regression tests in Turkish locale.
Bruce Momjian [Thu, 6 May 2004 19:32:09 +0000 (19:32 +0000)]
Done:
> o -ALTER TABLE ADD COLUMN column SERIAL doesn't create sequence because
Bruce Momjian [Thu, 6 May 2004 19:23:25 +0000 (19:23 +0000)]
sysv_shmem.c patch is to correct a bug that prevents the postmaster
recovering from an unexpected backend termination.
The remaining patches are to allow whitespace in db/install directory
names.
Claudio Natoli
Bruce Momjian [Thu, 6 May 2004 16:59:16 +0000 (16:59 +0000)]
Erase MD5 user passwords when a user is renamed because the username is
used as salt for the MD5 password.
Bruce Momjian [Thu, 6 May 2004 16:49:13 +0000 (16:49 +0000)]
Update todo/faq timestamps
Tom Lane [Thu, 6 May 2004 16:10:57 +0000 (16:10 +0000)]
Make ALTER COLUMN TYPE preserve clustered status for indexes it doesn't
modify. Also fix a passel of problems with ALTER TABLE CLUSTER ON:
failure to check that the index is safe to cluster on (or even belongs
to the indicated rel, or even exists), and failure to broadcast a relcache
flush event when changing an index's state.
Tom Lane [Thu, 6 May 2004 14:01:33 +0000 (14:01 +0000)]
Rewrite nodeRead() in a less obfuscated fashion, per discussion with
Neil Conway.
Neil Conway [Thu, 6 May 2004 06:11:01 +0000 (06:11 +0000)]
Fix grammatical error in comment.
Tom Lane [Wed, 5 May 2004 21:18:29 +0000 (21:18 +0000)]
Second try at a portable unsetenv().
Tom Lane [Wed, 5 May 2004 17:28:46 +0000 (17:28 +0000)]
Don't assume that struct timeval's tv_sec field is the same datatype as
time_t; on some platforms they are not the same width. Per Manfred Koizar.
Tom Lane [Wed, 5 May 2004 17:06:56 +0000 (17:06 +0000)]
Fix get_rels_with_domain to not do the wrong thing with views and
composite types that use a domain.
Tom Lane [Wed, 5 May 2004 16:09:31 +0000 (16:09 +0000)]
Use a more portable technique for unsetting environment variables,
and unset PGCLIENTENCODING to prevent backend from dying if it's set
to something incompatible with the -E option.
Michael Meskes [Wed, 5 May 2004 15:03:04 +0000 (15:03 +0000)]
- Fixed bug in adjust_informix that treated arrays as simple variables.
- Synced parser again.
- Synced lexer.
Bruce Momjian [Wed, 5 May 2004 14:36:20 +0000 (14:36 +0000)]
Done:
o -ALTER TABLE ADD COLUMN does not honor DEFAULT and non-CHECK CONSTRAINT
o -ALTER TABLE ADD COLUMN column DEFAULT should fill existing
rows with DEFAULT value
o -Allow ALTER TABLE to modify column lengths and change to binary
compatible types
Remove:
o Allow columns to be reordered using ALTER ... POSITION i col1 [,col2];
have SELECT * and INSERT honor such ordering
Neil Conway [Wed, 5 May 2004 09:33:38 +0000 (09:33 +0000)]
Fix a typo in the documentation.
Tom Lane [Wed, 5 May 2004 04:48:48 +0000 (04:48 +0000)]
ALTER TABLE rewrite. New cool stuff:
* ALTER ... ADD COLUMN with defaults and NOT NULL constraints works per SQL
spec. A default is implemented by rewriting the table with the new value
stored in each row.
* ALTER COLUMN TYPE. You can change a column's datatype to anything you
want, so long as you can specify how to convert the old value. Rewrites
the table. (Possible future improvement: optimize no-op conversions such
as varchar(N) to varchar(N+1).)
* Multiple ALTER actions in a single ALTER TABLE command. You can perform
any number of column additions, type changes, and constraint additions with
only one pass over the table contents.
Basic documentation provided in ALTER TABLE ref page, but some more docs
work is needed.
Original patch from Rod Taylor, additional work from Tom Lane.
Bruce Momjian [Mon, 3 May 2004 13:25:23 +0000 (13:25 +0000)]
More PWD adjustments for win32.
Neil Conway [Mon, 3 May 2004 08:47:54 +0000 (08:47 +0000)]
Fix obscure typo in 7.4.0 release notes.
Bruce Momjian [Sun, 2 May 2004 21:30:08 +0000 (21:30 +0000)]
Use $build_platform for PWD flag test, per suggestion from Peter.
Bruce Momjian [Sun, 2 May 2004 13:39:51 +0000 (13:39 +0000)]
Update catalog version for acl removal changes.
Bruce Momjian [Sun, 2 May 2004 13:38:28 +0000 (13:38 +0000)]
Revert patch --- needs more generalized solution.
> Please find a attached a small patch that adds accessor functions
> for "aclitem" so that it is not an opaque datatype.
>
> I needed these functions to browse aclitems from user land. I can load
> them when necessary, but it seems to me that these accessors for a
> backend type belong to the backend, so I submit them.
>
> Fabien Coelho
Bruce Momjian [Sun, 2 May 2004 12:27:45 +0000 (12:27 +0000)]
Assign item:
< o Add ALTER TABLE table SET WITHOUT CLUSTER
> o Add ALTER TABLE table SET WITHOUT CLUSTER (Christopher)
Bruce Momjian [Sun, 2 May 2004 12:27:00 +0000 (12:27 +0000)]
Update TODO item:
o Add ALTER TABLE table SET WITHOUT CLUSTER
Bruce Momjian [Sun, 2 May 2004 10:24:51 +0000 (10:24 +0000)]
Set PWDFLAGS based on test platform, not target platform.
Andrew Dunstan
Bruce Momjian [Sun, 2 May 2004 04:27:37 +0000 (04:27 +0000)]
this patch makes sure that:
* correct platform specific regression files are used under ming
* pwd prints out a usable win32 pathname
Claudio Natoli
Bruce Momjian [Sun, 2 May 2004 04:25:45 +0000 (04:25 +0000)]
Set std error to no buffering on Win32.
Bruce Momjian [Sun, 2 May 2004 03:12:12 +0000 (03:12 +0000)]
More win32 adjustment for timezone directory.
Bruce Momjian [Sat, 1 May 2004 22:07:03 +0000 (22:07 +0000)]
Fix timezone data path for Unix and win32.
Bruce Momjian [Sat, 1 May 2004 19:25:08 +0000 (19:25 +0000)]
Align prototype in C code.
Bruce Momjian [Sat, 1 May 2004 01:38:53 +0000 (01:38 +0000)]
Remove debug output line.
Bruce Momjian [Sat, 1 May 2004 01:34:47 +0000 (01:34 +0000)]
Rename function to be less win32 specific.
Bruce Momjian [Sat, 1 May 2004 01:27:03 +0000 (01:27 +0000)]
Update Japanese FAQ.
Jun Kuwamura
Bruce Momjian [Fri, 30 Apr 2004 20:47:33 +0000 (20:47 +0000)]
Suppress use of timezone library by ecpg.
Bruce Momjian [Fri, 30 Apr 2004 20:23:28 +0000 (20:23 +0000)]
Fix zic compiler to use pg version.
Move timezone database to share/timezone.
Bruce Momjian [Fri, 30 Apr 2004 20:01:39 +0000 (20:01 +0000)]
Allow build of timezone database on unix.
Bruce Momjian [Fri, 30 Apr 2004 17:52:07 +0000 (17:52 +0000)]
More timezone build adjustments.
Bruce Momjian [Fri, 30 Apr 2004 16:58:48 +0000 (16:58 +0000)]
Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h:
#ifndef HAVE_SYMLINK
#define HAVE_SYMLINK 0
#endif
Bruce Momjian [Fri, 30 Apr 2004 16:08:01 +0000 (16:08 +0000)]
More cleanups for USE_PGTZ.
Bruce Momjian [Fri, 30 Apr 2004 15:01:25 +0000 (15:01 +0000)]
Rename to USE_PGTZ to match code.
Bruce Momjian [Fri, 30 Apr 2004 14:24:14 +0000 (14:24 +0000)]
Allow timezone to compile under Unix by blocking 'timezone' conflict with
system headers.
Allow system to find timezone database by pasing pkglibdir into the
binary via a define.
Bruce Momjian [Fri, 30 Apr 2004 04:44:06 +0000 (04:44 +0000)]
Convert DOS newlines to Unix newlines.
Bruce Momjian [Fri, 30 Apr 2004 04:31:52 +0000 (04:31 +0000)]
Integrate timezone library to be called only from Win32.
Timezone code backend integration done by Magnus Hagander.
Bruce Momjian [Fri, 30 Apr 2004 04:18:28 +0000 (04:18 +0000)]
Enable use of our own timezone library for Win32.
Bruce Momjian [Fri, 30 Apr 2004 04:14:06 +0000 (04:14 +0000)]
Minor adjustments to enable public-domain timezone library to be called
from our code.
Bruce Momjian [Fri, 30 Apr 2004 04:11:58 +0000 (04:11 +0000)]
Timezone library changes to map into our backend code.
Bruce Momjian [Fri, 30 Apr 2004 04:09:23 +0000 (04:09 +0000)]
Add Olson's public domain timezone library to src/timezone.
Michael Meskes [Thu, 29 Apr 2004 14:08:10 +0000 (14:08 +0000)]
Synced parser and keyword list.
Tom Lane [Thu, 29 Apr 2004 04:37:09 +0000 (04:37 +0000)]
Minor copy-editing.
Bruce Momjian [Wed, 28 Apr 2004 16:35:36 +0000 (16:35 +0000)]
Fix typo:
< columns and indexes with many duplicate keys
Bruce Momjian [Tue, 27 Apr 2004 20:09:27 +0000 (20:09 +0000)]
Improve thread failure wording.
Bruce Momjian [Tue, 27 Apr 2004 20:06:52 +0000 (20:06 +0000)]
Enable thread testing outside the source tree.
Bruce Momjian [Tue, 27 Apr 2004 19:51:12 +0000 (19:51 +0000)]
Do thread testing from configure in a much cleaner fashion.
Bruce Momjian [Tue, 27 Apr 2004 18:40:50 +0000 (18:40 +0000)]
Add comments.
Bruce Momjian [Tue, 27 Apr 2004 18:36:31 +0000 (18:36 +0000)]
Use mktemp for temporary file names, per suggestion from Peter.
Bruce Momjian [Tue, 27 Apr 2004 17:22:41 +0000 (17:22 +0000)]
Move postgres.h to the top of the C file.
Bruce Momjian [Mon, 26 Apr 2004 19:08:57 +0000 (19:08 +0000)]
Fix vpath for thread test.
Bruce Momjian [Mon, 26 Apr 2004 18:32:33 +0000 (18:32 +0000)]
Fix subdir for thread test program.
Bruce Momjian [Mon, 26 Apr 2004 17:40:48 +0000 (17:40 +0000)]
Add $(X) for cross-compiling. Seems the mingw compiler running on
FreeBSD doesn't add .EXE to links.
Michiel Ephraim
Bruce Momjian [Mon, 26 Apr 2004 15:24:42 +0000 (15:24 +0000)]
Please find attached a small patch against current cvs head, so that
'information_schema' is considered a system schema by various
pg_stat*_*_{tables,sequences} views.
Fabien COELHO
Bruce Momjian [Mon, 26 Apr 2004 15:06:49 +0000 (15:06 +0000)]
Please find a attached a small patch that adds accessor functions
for "aclitem" so that it is not an opaque datatype.
I needed these functions to browse aclitems from user land. I can load
them when necessary, but it seems to me that these accessors for a
backend type belong to the backend, so I submit them.
Fabien Coelho
Bruce Momjian [Mon, 26 Apr 2004 13:14:48 +0000 (13:14 +0000)]
More cleanup of thread tests.
Dennis Bjorklund [Mon, 26 Apr 2004 06:33:10 +0000 (06:33 +0000)]
Translation updates
Bruce Momjian [Mon, 26 Apr 2004 04:04:42 +0000 (04:04 +0000)]
Unconditionally define:
-D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS
for all ports. It can't hurt if they are not supported, but it makes
our job easier for porting.
Should fix Darwin compile and other platforms without mucking with the
thread detection code.
Bruce Momjian [Mon, 26 Apr 2004 00:48:38 +0000 (00:48 +0000)]
Clean tools/thread on make clean/distclean.
Bruce Momjian [Mon, 26 Apr 2004 00:44:39 +0000 (00:44 +0000)]
Exit with non-zero error on thread test failures.
Bruce Momjian [Mon, 26 Apr 2004 00:38:25 +0000 (00:38 +0000)]
More thread error improvments.
Bruce Momjian [Mon, 26 Apr 2004 00:36:18 +0000 (00:36 +0000)]
More thread error message improvments.
Bruce Momjian [Mon, 26 Apr 2004 00:34:12 +0000 (00:34 +0000)]
More thread error improvements.
Bruce Momjian [Mon, 26 Apr 2004 00:32:00 +0000 (00:32 +0000)]
Improve thread error message.
Bruce Momjian [Mon, 26 Apr 2004 00:29:24 +0000 (00:29 +0000)]
Improve error message for platform thread failure.
Neil Conway [Sun, 25 Apr 2004 23:50:58 +0000 (23:50 +0000)]
Tiny assorted fixes: correct a typo in a comment in vacuumlazy.c, remove
some unused #include directives from bufmgr.c, and clarify comments in
bufmgr.h and buf.h
Bruce Momjian [Sun, 25 Apr 2004 21:09:08 +0000 (21:09 +0000)]
More thread cleanups.
Bruce Momjian [Sun, 25 Apr 2004 21:04:59 +0000 (21:04 +0000)]
Add mention to check config.log if thread test failure.
Bruce Momjian [Sun, 25 Apr 2004 21:03:27 +0000 (21:03 +0000)]
Fix typo on thread lib name.
Bruce Momjian [Sun, 25 Apr 2004 20:57:32 +0000 (20:57 +0000)]
Make thread flags CFLAGS, not CPPFLAGS.
Bruce Momjian [Sun, 25 Apr 2004 20:47:56 +0000 (20:47 +0000)]
No need to use our standard libs for the thread test --- they might not
be compiled yet.
Neil Conway [Sun, 25 Apr 2004 18:23:57 +0000 (18:23 +0000)]
Remove the last traces of Joe Hellerstein's "xfunc" optimization. Patch
from Alvaro Herrera. Also, removed lispsort.c, since it is no longer
used.
Neil Conway [Sat, 24 Apr 2004 22:58:40 +0000 (22:58 +0000)]
Fix typo in libpq docs.
Neil Conway [Sat, 24 Apr 2004 22:53:44 +0000 (22:53 +0000)]
Document that PQoidValue(), PQcmdTuples(), and PQoidStatus() now work
when the command that generated the PGresult was an EXECUTE of an
appropriate prepared statement.
Tom Lane [Sat, 24 Apr 2004 20:10:34 +0000 (20:10 +0000)]
Ensure getaddrinfo_all returns null result on failure.
Bruce Momjian [Sat, 24 Apr 2004 03:09:35 +0000 (03:09 +0000)]
Check for gmake, then make, when doing thread test.
Bruce Momjian [Sat, 24 Apr 2004 00:14:28 +0000 (00:14 +0000)]
Add mention to run thread test program if user is experiencing problems
with threaded applications.
Bruce Momjian [Fri, 23 Apr 2004 23:58:12 +0000 (23:58 +0000)]
Hook thread_test program run at the end of configure run.
Add test for cross-compiles that they have to run the thread_test
program on the target machine.