From: Peter Eisentraut <peter@eisentraut.org>
Date: Mon, 27 Apr 2020 12:24:20 +0000 (+0200)
Subject: pg_dump: Replace can't-happen error with assertion
X-Git-Tag: REL_13_BETA1~164
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=d51f704fd8cbae03cd9b29fe103dd027d521ff04;p=postgresql.git

pg_dump: Replace can't-happen error with assertion
---

diff --git a/src/bin/pg_dump/pg_backup_tar.c b/src/bin/pg_dump/pg_backup_tar.c
index 775118f2978..d5bfa556461 100644
--- a/src/bin/pg_dump/pg_backup_tar.c
+++ b/src/bin/pg_dump/pg_backup_tar.c
@@ -515,6 +515,8 @@ _tarReadRaw(ArchiveHandle *AH, void *buf, size_t len, TAR_MEMBER *th, FILE *fh)
 	size_t		used = 0;
 	size_t		res = 0;
 
+	Assert(th || fh);
+
 	avail = AH->lookaheadLen - AH->lookaheadPos;
 	if (avail > 0)
 	{
@@ -567,8 +569,6 @@ _tarReadRaw(ArchiveHandle *AH, void *buf, size_t len, TAR_MEMBER *th, FILE *fh)
 					READ_ERROR_EXIT(th->nFH);
 			}
 		}
-		else
-			fatal("internal error -- neither th nor fh specified in _tarReadRaw()");
 	}
 
 	ctx->tarFHpos += res + used;