From: Robert Haas <rhaas@postgresql.org>
Date: Wed, 5 Nov 2014 22:12:23 +0000 (-0500)
Subject: Fix thinko in commit 2bd9e412f92bc6a68f3e8bcb18e04955cc35001d.
X-Git-Tag: REL9_5_ALPHA1~1265
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=c30be9787bd9808631b72843b0a93f06ce775dd0;p=postgresql.git

Fix thinko in commit 2bd9e412f92bc6a68f3e8bcb18e04955cc35001d.

Obviously, every translation unit should not be declaring this
separately.  It needs to be PGDLLIMPORT as well, to avoid breaking
third-party code that uses any of the functions that the commit
mentioned above changed to macros.
---

diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
index dcbb704c6a5..74161970ab5 100644
--- a/src/backend/libpq/pqcomm.c
+++ b/src/backend/libpq/pqcomm.c
@@ -105,6 +105,8 @@ char	   *Unix_socket_group;
 /* Where the Unix socket files are (list of palloc'd strings) */
 static List *sock_paths = NIL;
 
+PQcommMethods *PqCommMethods;
+
 
 /*
  * Buffers for low-level I/O.
diff --git a/src/include/libpq/libpq.h b/src/include/libpq/libpq.h
index 409f3d7786e..2a61a9e143d 100644
--- a/src/include/libpq/libpq.h
+++ b/src/include/libpq/libpq.h
@@ -49,7 +49,7 @@ typedef struct
 	void (*endcopyout)(bool errorAbort);
 } PQcommMethods;
 
-PQcommMethods *PqCommMethods;
+extern PGDLLIMPORT PQcommMethods *PqCommMethods;
 
 #define pq_comm_reset()	(PqCommMethods->comm_reset())
 #define pq_flush() (PqCommMethods->flush())