From: Noah Misch <noah@leadboat.com>
Date: Fri, 6 Sep 2013 23:42:00 +0000 (-0400)
Subject: Don't VALGRIND_PRINTF() each query string.
X-Git-Tag: REL9_4_BETA1~1162
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=b8104730c8eae1f81ccbc8673bbd2a3566e660ae;p=postgresql.git

Don't VALGRIND_PRINTF() each query string.

Doing so was helpful for some Valgrind usage and distracting for other
usage.  One can achieve the same effect by changing log_statement and
pointing both PostgreSQL and Valgrind logging to stderr.

Per gripe from Andres Freund.
---

diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
index ddd60dee4f4..e56dbfb8006 100644
--- a/src/backend/tcop/postgres.c
+++ b/src/backend/tcop/postgres.c
@@ -69,7 +69,6 @@
 #include "tcop/tcopprot.h"
 #include "tcop/utility.h"
 #include "utils/lsyscache.h"
-#include "utils/memdebug.h"
 #include "utils/memutils.h"
 #include "utils/ps_status.h"
 #include "utils/snapmgr.h"
@@ -847,10 +846,6 @@ exec_simple_query(const char *query_string)
 
 	TRACE_POSTGRESQL_QUERY_START(query_string);
 
-#ifdef USE_VALGRIND
-	VALGRIND_PRINTF("statement: %s\n", query_string);
-#endif
-
 	/*
 	 * We use save_log_statement_stats so ShowUsage doesn't report incorrect
 	 * results because ResetUsage wasn't called.