From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 4 Jun 2017 00:35:52 +0000 (-0400)
Subject: Remove dead variables.
X-Git-Tag: REL_10_BETA2~240
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=5936d25f8101f2433e8242794d2275c7a05273bf;p=postgresql.git

Remove dead variables.

Commit 512c7356b left a couple of variables unused except for being set.
My compiler didn't whine about this, but some buildfarm members did.
---

diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.c
index 52d0e48995a..300a8ff7e54 100644
--- a/src/backend/utils/adt/selfuncs.c
+++ b/src/backend/utils/adt/selfuncs.c
@@ -336,13 +336,10 @@ var_eq_const(VariableStatData *vardata, Oid operator,
 			 statistic_proc_security_check(vardata,
 										 (opfuncoid = get_opcode(operator))))
 	{
-		Form_pg_statistic stats;
 		AttStatsSlot sslot;
 		bool		match = false;
 		int			i;
 
-		stats = (Form_pg_statistic) GETSTRUCT(vardata->statsTuple);
-
 		/*
 		 * Is the constant "=" to any of the column's most common values?
 		 * (Although the given operator may not really be "=", we will assume
@@ -480,12 +477,9 @@ var_eq_non_const(VariableStatData *vardata, Oid operator,
 	}
 	else if (HeapTupleIsValid(vardata->statsTuple))
 	{
-		Form_pg_statistic stats;
 		double		ndistinct;
 		AttStatsSlot sslot;
 
-		stats = (Form_pg_statistic) GETSTRUCT(vardata->statsTuple);
-
 		/*
 		 * Search is for a value that we do not know a priori, but we will
 		 * assume it is not NULL.  Estimate the selectivity as non-null