From: Andres Freund <andres@anarazel.de>
Date: Wed, 1 May 2019 00:45:32 +0000 (-0700)
Subject: Fix unused variable compiler warning in !debug builds.
X-Git-Tag: REL9_5_17~9
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=5409e359f81488056fb690c7aef0fd79d8a118d6;p=postgresql.git

Fix unused variable compiler warning in !debug builds.

Introduced in 3dbb317d3.  Fix by using the new local variable in more
places.

Reported-By: Bruce Momjian (off-list)
Backpatch: 9.4-, like 3dbb317d3
---

diff --git a/src/backend/catalog/indexing.c b/src/backend/catalog/indexing.c
index 2d6e140087d..dd617f8f83d 100644
--- a/src/backend/catalog/indexing.c
+++ b/src/backend/catalog/indexing.c
@@ -135,7 +135,7 @@ CatalogIndexInsert(CatalogIndexState indstate, HeapTuple heapTuple)
 			Assert(!ReindexIsProcessingIndex(RelationGetRelid(index)));
 			continue;
 		}
-#endif /* USE_ASSERT_CHECKING */
+#endif							/* USE_ASSERT_CHECKING */
 
 		/*
 		 * FormIndexDatum fills in its values and isnull parameters with the
@@ -150,12 +150,12 @@ CatalogIndexInsert(CatalogIndexState indstate, HeapTuple heapTuple)
 		/*
 		 * The index AM does the rest.
 		 */
-		index_insert(relationDescs[i],	/* index relation */
+		index_insert(index,		/* index relation */
 					 values,	/* array of index Datums */
 					 isnull,	/* is-null flags */
 					 &(heapTuple->t_self),		/* tid of heap tuple */
 					 heapRelation,
-					 relationDescs[i]->rd_index->indisunique ?
+					 index->rd_index->indisunique ?
 					 UNIQUE_CHECK_YES : UNIQUE_CHECK_NO);
 	}