From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 22 Oct 2013 04:38:53 +0000 (-0400)
Subject: Fix blatantly broken record_image_cmp() logic for pass-by-value fields.
X-Git-Tag: REL9_4_BETA1~1028
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=28858811472f316f73eba0e564837088fc8c6ccd;p=postgresql.git

Fix blatantly broken record_image_cmp() logic for pass-by-value fields.

Doesn't anybody here pay attention to compiler warnings?
---

diff --git a/src/backend/utils/adt/rowtypes.c b/src/backend/utils/adt/rowtypes.c
index ae007cfe319..cb04a724d3b 100644
--- a/src/backend/utils/adt/rowtypes.c
+++ b/src/backend/utils/adt/rowtypes.c
@@ -1430,7 +1430,7 @@ record_image_cmp(FunctionCallInfo fcinfo)
 		 */
 		if (!nulls1[i1] || !nulls2[i2])
 		{
-			int			cmpresult;
+			int			cmpresult = 0;
 
 			if (nulls1[i1])
 			{