From: Alexander Korotkov <akorotkov@postgresql.org>
Date: Sun, 29 Oct 2023 22:23:53 +0000 (+0300)
Subject: Fix instable 006_login_trigger.pl test
X-Git-Tag: REL_17_BETA1~1586
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=06be01eb266bdb24efd931ad10ee6a1de26271b4;p=postgresql.git

Fix instable 006_login_trigger.pl test

Handling of login trigger FATAL error could cause a timing-dependant panic of
IPC::Run.  This commit excludes checks which involves handling of such errors.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/2268825.1698618066%40sss.pgh.pa.us
---

diff --git a/src/test/authentication/t/006_login_trigger.pl b/src/test/authentication/t/006_login_trigger.pl
index 24beb0a0b2d..3f1a8a7c457 100644
--- a/src/test/authentication/t/006_login_trigger.pl
+++ b/src/test/authentication/t/006_login_trigger.pl
@@ -143,27 +143,16 @@ psql_command(
 	log_exact => '2',
 	err_like => [qr/You are welcome/]);
 
-# Try to log as allowed Alice and disallowed Mallory (two times)
+# Try to login as allowed Alice.  We don't check the Mallroy login, because
+# FATAL error could cause a timing-dependant panic of IPC::Run.
 psql_command(
 	$node, 'SELECT 1;', 0, 'try regress_alice',
 	connstr => 'user=regress_alice',
 	log_exact => '1',
 	err_like => [qr/You are welcome/],
 	err_unlike => [qr/You are NOT welcome/]);
-psql_command(
-	$node, 'SELECT 1;', 2, 'try regress_mallory',
-	connstr => 'user=regress_mallory',
-	log_exact => '',
-	err_like => [qr/You are NOT welcome/],
-	err_unlike => [qr/You are welcome/]);
-psql_command(
-	$node, 'SELECT 1;', 2, 'try regress_mallory',
-	connstr => 'user=regress_mallory',
-	log_exact => '',
-	err_like => [qr/You are NOT welcome/],
-	err_unlike => [qr/You are welcome/]);
 
-# Check that Alice's login record is here, while the Mallory's one is not
+# Check that Alice's login record is here
 psql_command(
 	$node, 'SELECT * FROM user_logins;', 0, 'select *',
 	log_like => [qr/3\|regress_alice/],