From: Alexander Korotkov <akorotkov@postgresql.org>
Date: Sun, 17 Mar 2019 07:10:21 +0000 (+0300)
Subject: Fix compiler warning in jsonpath_exec.c
X-Git-Tag: REL_12_BETA1~516
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=042162d6281a7daf1291931ee7b0a5641d3a73d7;p=postgresql.git

Fix compiler warning in jsonpath_exec.c

Warning was observed in gcc 4.4.6, gcc 4.4.7 and probably others.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/25151.1552751426%40sss.pgh.pa.us
---

diff --git a/src/backend/utils/adt/jsonpath_exec.c b/src/backend/utils/adt/jsonpath_exec.c
index 4fc441f11e7..c07225749e5 100644
--- a/src/backend/utils/adt/jsonpath_exec.c
+++ b/src/backend/utils/adt/jsonpath_exec.c
@@ -1459,15 +1459,11 @@ executePredicate(JsonPathExecContext *cxt, JsonPathItem *pred,
 		JsonbValue *rval;
 		bool		first = true;
 
+		JsonValueListInitIterator(&rseq, &rseqit);
 		if (rarg)
-		{
-			JsonValueListInitIterator(&rseq, &rseqit);
 			rval = JsonValueListNext(&rseq, &rseqit);
-		}
 		else
-		{
 			rval = NULL;
-		}
 
 		/* Loop over right arg sequence or do single pass otherwise */
 		while (rarg ? (rval != NULL) : first)