Save Kerberos and LDAP daemon logs where the buildfarm can find them.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 6 Aug 2019 21:08:07 +0000 (17:08 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 6 Aug 2019 21:08:38 +0000 (17:08 -0400)
src/test/kerberos and src/test/ldap try to run private authentication
servers, which of course might fail.  The logs from these servers
were being dropped into the tmp_check/ subdirectory, but they should
be put in tmp_check/log/, because the buildfarm will only capture
log files in that subdirectory.  Without the log output there's
little hope of diagnosing buildfarm failures related to these servers.

Backpatch to v11 where these test suites were added.

Discussion: https://postgr.es/m/16017.1565047605@sss.pgh.pa.us

src/test/kerberos/t/001_auth.pl
src/test/ldap/t/001_auth.pl

index d0fc45e5869164caad15cad9d25c27c1c88232b0..32811010523e363fde81863f435037e1505f7b79 100644 (file)
@@ -54,8 +54,8 @@ my $realm = 'EXAMPLE.COM';
 
 my $krb5_conf   = "${TestLib::tmp_check}/krb5.conf";
 my $kdc_conf    = "${TestLib::tmp_check}/kdc.conf";
-my $krb5_log    = "${TestLib::tmp_check}/krb5libs.log";
-my $kdc_log     = "${TestLib::tmp_check}/krb5kdc.log";
+my $krb5_log    = "${TestLib::log_path}/krb5libs.log";
+my $kdc_log     = "${TestLib::log_path}/krb5kdc.log";
 my $kdc_port    = get_free_port();
 my $kdc_datadir = "${TestLib::tmp_check}/krb5kdc";
 my $kdc_pidfile = "${TestLib::tmp_check}/krb5kdc.pid";
index 3b071753fd0ff7391b7980d7c8181ea9aca3dfa6..ef01b9fb61e7e8125a7d61554f01cb2e21a92d43 100644 (file)
@@ -45,7 +45,7 @@ my $ldap_datadir  = "${TestLib::tmp_check}/openldap-data";
 my $slapd_certs   = "${TestLib::tmp_check}/slapd-certs";
 my $slapd_conf    = "${TestLib::tmp_check}/slapd.conf";
 my $slapd_pidfile = "${TestLib::tmp_check}/slapd.pid";
-my $slapd_logfile = "${TestLib::tmp_check}/slapd.log";
+my $slapd_logfile = "${TestLib::log_path}/slapd.log";
 my $ldap_conf     = "${TestLib::tmp_check}/ldap.conf";
 my $ldap_server   = 'localhost';
 my $ldap_port     = get_free_port();