Fix file descriptor leak after failure of a \setshell command in pgbench.

If the called command fails to return data, runShellCommand forgot to
pclose() the pipe before returning.  This is fairly harmless in the current
code, because pgbench would then abandon further processing of that client
thread; so no more than nclients descriptors could be leaked this way.  But
it's not hard to imagine future improvements whereby that wouldn't be true.
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.

diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
index 5d7ad96cfffaaff05b5d4e088d6a55148be076e7..d87e75c7702f72bc4a9dbad53685f1b04c886e17 100644 (file)
--- a/contrib/pgbench/pgbench.c
+++ b/contrib/pgbench/pgbench.c
@@ -749,6 +749,7 @@ runShellCommand(CState *st, char *variable, char **argv, int argc)
    {
        if (!timer_exceeded)
            fprintf(stderr, "%s: cannot read the result\n", argv[0]);
+       (void) pclose(fp);
        return false;
    }
    if (pclose(fp) < 0)