Revert "Prevent instability in contrib/pageinspect's regression test."

This reverts commit 5cda142bb9d2bd7e7ed1c22ae89afe58abfa8d7b
(in v14 only).

It turns out that that fails under force_parallel_mode = regress,
because pageinspect's disk-access functions are marked parallel
safe, which they are not if you try to use them on a temp table.
The cost of fixing that pre-v15 seems to exceed the value of
making this test case fully stable, so we will just leave things
as-is in v14.

diff --git a/contrib/pageinspect/expected/page.out b/contrib/pageinspect/expected/page.out
index 9e4e70ce7c5f6d2c052b26146044cea971f005de..8134eda1d7e95ccc5d6c13012cd51440f974fa0c 100644 (file)
--- a/contrib/pageinspect/expected/page.out
+++ b/contrib/pageinspect/expected/page.out
@@ -1,6 +1,5 @@
 CREATE EXTENSION pageinspect;
--- Use a temp table so that effects of VACUUM are predictable
-CREATE TEMP TABLE test1 (a int, b int);
+CREATE TABLE test1 (a int, b int);
 INSERT INTO test1 VALUES (16777217, 131584);
 VACUUM (DISABLE_PAGE_SKIPPING) test1;  -- set up FSM
 -- The page contents can vary, so just test that it can be read

diff --git a/contrib/pageinspect/sql/page.sql b/contrib/pageinspect/sql/page.sql
index 5bff568d3b5f8c4c7afd08383050cb4e61f5712b..b5c41cc8ac53a1e00c3f5b20aa57aef04080b2ee 100644 (file)
--- a/contrib/pageinspect/sql/page.sql
+++ b/contrib/pageinspect/sql/page.sql
@@ -1,7 +1,6 @@
 CREATE EXTENSION pageinspect;
 
--- Use a temp table so that effects of VACUUM are predictable
-CREATE TEMP TABLE test1 (a int, b int);
+CREATE TABLE test1 (a int, b int);
 INSERT INTO test1 VALUES (16777217, 131584);
 
 VACUUM (DISABLE_PAGE_SKIPPING) test1;  -- set up FSM