Allow pg_upgrade to upgrade clusters that use exclusion contraints by

fixing pg_dump to properly preserve such indexes.

Backpatch to 9.1 and 9.0 (where the bug was introduced).

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 9bbf962cd0101b8ed50d25e7bf5fbb032d26892c..28a527357f9e0bd8bec3333fc3867028d00fec22 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -12948,7 +12948,7 @@ dumpConstraint(Archive *fout, ConstraintInfo *coninfo)
            exit_nicely();
        }
 
-       if (binary_upgrade && !coninfo->condef)
+       if (binary_upgrade)
            binary_upgrade_set_pg_class_oids(q, indxinfo->dobj.catId.oid, true);
 
        appendPQExpBuffer(q, "ALTER TABLE ONLY %s\n",