Fix coding rules violations in walreceiver.c

1. Since commit b1a9bad9e744 we had pstrdup() inside a
spinlock-protected critical section; reported by Andreas Seltenreich.
Turn those into strlcpy() to stack-allocated variables instead.
Backpatch to 9.6.

2. Since commit 9ed551e0a4fd we had a pfree() uselessly inside a
spinlock-protected critical section.  Tom Lane noticed in code review.
Move down.  Backpatch to 9.6.

3. Since commit 64233902d22b we had GetCurrentTimestamp() (a kernel
call) inside a spinlock-protected critical section.  Tom Lane noticed in
code review.  Move it up.  Backpatch to 9.2.

4. Since commit 1bb2558046cc we did elog(PANIC) while holding spinlock.
Tom Lane noticed in code review.  Release spinlock before dying.
Backpatch to 9.2.

Discussion: https://postgr.es/m/87h8vhtgj2.fsf@ansel.ydns.eu

diff --git a/src/backend/replication/walreceiver.c b/src/backend/replication/walreceiver.c
index 42f6c26f28b0d3aebc57dae654026614bf6ab578..600f5d53ebaf062bb8de25751019181b94e8efca 100644 (file)
--- a/src/backend/replication/walreceiver.c
+++ b/src/backend/replication/walreceiver.c
@@ -196,6 +196,7 @@ WalReceiverMain(void)
    /* use volatile pointer to prevent code rearrangement */
    volatile WalRcvData *walrcv = WalRcv;
    TimestampTz last_recv_timestamp;
+   TimestampTz now;
    bool        ping_sent;
 
    /*
@@ -204,6 +205,8 @@ WalReceiverMain(void)
     */
    Assert(walrcv != NULL);
 
+   now = GetCurrentTimestamp();
+
    /*
     * Mark walreceiver as running in shared memory.
     *
@@ -234,6 +237,7 @@ WalReceiverMain(void)
        case WALRCV_RESTARTING:
        default:
            /* Shouldn't happen */
+           SpinLockRelease(&walrcv->mutex);
            elog(PANIC, "walreceiver still running according to shared memory state");
    }
    /* Advertise our PID so that the startup process can kill us */
@@ -247,7 +251,8 @@ WalReceiverMain(void)
    startpointTLI = walrcv->receiveStartTLI;
 
    /* Initialise to a sanish value */
-   walrcv->lastMsgSendTime = walrcv->lastMsgReceiptTime = walrcv->latestWalEndTime = GetCurrentTimestamp();
+   walrcv->lastMsgSendTime =
+       walrcv->lastMsgReceiptTime = walrcv->latestWalEndTime = now;
 
    SpinLockRelease(&walrcv->mutex);