When a TAP file has non-zero exit status, retain temporary directories.

PostgresNode already retained base directories in such cases.  Stop
using $SIG{__DIE__}, which is redundant with the exit status check, in
lieu of proliferating it to TestLib.  Back-patch to 9.6, where commit
88802e068017bee8cea7a5502a712794e761c7b5 introduced retention on
failure.

Reviewed by Daniel Gustafsson.

Discussion: https://postgr.es/m/20200202170155.GA3264196@rfd.leadboat.com

diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
index 713a1214e711cd689ee2f27b530d3aeb3c4aa88b..76af7dd7345776b6b5f3024f8ba6fa4668bde8db 100644 (file)
--- a/src/test/perl/TestLib.pm
+++ b/src/test/perl/TestLib.pm
@@ -111,8 +111,13 @@ INIT
 END
 {
 
-   # Preserve temporary directory for this test on failure
-   $File::Temp::KEEP_ALL = 1 unless all_tests_passing();
+   # Test files have several ways of causing prove_check to fail:
+   # 1. Exit with a non-zero status.
+   # 2. Call ok(0) or similar, indicating that a constituent test failed.
+   # 3. Deviate from the planned number of tests.
+   #
+   # Preserve temporary directories after (1) and after (2).
+   $File::Temp::KEEP_ALL = 1 unless $? == 0 && all_tests_passing();
 }
 
 sub all_tests_passing