Pass collations to functions in FunctionCallInfoData, not FmgrInfo.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 12 Apr 2011 23:19:24 +0000 (19:19 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 12 Apr 2011 23:19:24 +0000 (19:19 -0400)
commitd64713df7e5996ab3ab337b5e0901cf2c53773f9
tree7105a61bf9fef5cef674cea7f1305dfeb77aa39a
parent88543ecfec9c754b5f14b898bccbc68d941748b3
Pass collations to functions in FunctionCallInfoData, not FmgrInfo.

Since collation is effectively an argument, not a property of the function,
FmgrInfo is really the wrong place for it; and this becomes critical in
cases where a cached FmgrInfo is used for varying purposes that might need
different collation settings.  Fix by passing it in FunctionCallInfoData
instead.  In particular this allows a clean fix for bug #5970 (record_cmp
not working).  This requires touching a bit more code than the original
method, but nobody ever thought that collations would not be an invasive
patch...
49 files changed:
contrib/btree_gin/btree_gin.c
contrib/btree_gist/btree_text.c
src/backend/access/common/reloptions.c
src/backend/access/common/scankey.c
src/backend/access/gin/ginget.c
src/backend/access/gin/ginutil.c
src/backend/access/gist/gistget.c
src/backend/access/gist/gistscan.c
src/backend/access/hash/hashutil.c
src/backend/access/index/indexam.c
src/backend/access/nbtree/nbtinsert.c
src/backend/access/nbtree/nbtsearch.c
src/backend/access/nbtree/nbtsort.c
src/backend/access/nbtree/nbtutils.c
src/backend/commands/analyze.c
src/backend/commands/trigger.c
src/backend/commands/tsearchcmds.c
src/backend/executor/execGrouping.c
src/backend/executor/execQual.c
src/backend/executor/execUtils.c
src/backend/executor/functions.c
src/backend/executor/nodeAgg.c
src/backend/executor/nodeIndexscan.c
src/backend/executor/nodeMergeAppend.c
src/backend/executor/nodeMergejoin.c
src/backend/executor/nodeSubplan.c
src/backend/executor/nodeWindowAgg.c
src/backend/optimizer/path/indxpath.c
src/backend/tcop/fastpath.c
src/backend/tsearch/wparser.c
src/backend/utils/adt/arrayfuncs.c
src/backend/utils/adt/int.c
src/backend/utils/adt/like.c
src/backend/utils/adt/oid.c
src/backend/utils/adt/ri_triggers.c
src/backend/utils/adt/rowtypes.c
src/backend/utils/adt/selfuncs.c
src/backend/utils/cache/catcache.c
src/backend/utils/fmgr/README
src/backend/utils/fmgr/fmgr.c
src/backend/utils/sort/tuplesort.c
src/include/access/gin_private.h
src/include/access/skey.h
src/include/access/valid.h
src/include/fmgr.h
src/include/nodes/execnodes.h
src/include/utils/selfuncs.h
src/include/utils/tuplesort.h
src/pl/plpgsql/src/pl_comp.c