pg_upgrade: prevent check on live cluster from generating error
authorBruce Momjian <bruce@momjian.us>
Tue, 9 Jan 2018 03:43:51 +0000 (22:43 -0500)
committerBruce Momjian <bruce@momjian.us>
Tue, 9 Jan 2018 03:43:51 +0000 (22:43 -0500)
commitd25ee30031b08ad1348a090914c2af6bc640a832
treed71669dc77e79e309c4f56a3000098423f184108
parente35dba475a440f73dccf9ed1fd61e3abc6ee61db
pg_upgrade:  prevent check on live cluster from generating error

Previously an inaccurate but harmless error was generated when running
--check on a live server before reporting the servers as compatible.
The fix is to split error reporting and exit control in the exec_prog()
API.

Reported-by: Daniel Westermann
Backpatch-through: 10
src/bin/pg_upgrade/dump.c
src/bin/pg_upgrade/exec.c
src/bin/pg_upgrade/parallel.c
src/bin/pg_upgrade/pg_upgrade.c
src/bin/pg_upgrade/pg_upgrade.h
src/bin/pg_upgrade/server.c