Be sure to close() file descriptor on error case
authorStephen Frost <sfrost@snowman.net>
Sun, 14 Jul 2013 21:30:43 +0000 (17:30 -0400)
committerStephen Frost <sfrost@snowman.net>
Sun, 14 Jul 2013 21:30:43 +0000 (17:30 -0400)
commitcec62efd0e551a56635b47ea4185ec27a6840de7
treefbc7e07f03a7ca64f4b61e65498a507ef93bfb66
parent273dcd16282c8014a14a9ecbf467459b8702e745
Be sure to close() file descriptor on error case

In receivelog.c:writeTimeLineHistoryFile(), we were not properly
closing the open'd file descriptor in error cases.  While this
wouldn't matter much if we were about to exit due to such an
error, that's not the case with pg_receivexlog as it can be a
long-running process and these errors are non-fatal.

This resource leak was found by the Coverity scanner.

Back-patch to 9.3 where this issue first appeared.
src/bin/pg_basebackup/receivelog.c