Fix an old bug in multixact and two-phase commit. Prepared transactions can
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 23 Nov 2009 09:58:36 +0000 (09:58 +0000)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 23 Nov 2009 09:58:36 +0000 (09:58 +0000)
commitcd87b6f8a5084c070c3e56b07794be8fea33647d
tree20c1c2d08a56147198288ea6845791a41e888c91
parentc194ff20d2fa1541d62c366bb6a9000fb0d3b983
Fix an old bug in multixact and two-phase commit. Prepared transactions can
be part of multixacts, so allocate a slot for each prepared transaction in
the "oldest member" array in multixact.c. On PREPARE TRANSACTION, transfer
the oldest member value from the current backends slot to the prepared xact
slot. Also save and recover the value from the 2pc state file.

The symptom of the bug was that after a transaction prepared, a shared lock
still held by the prepared transaction was sometimes ignored by other
transactions.

Fix back to 8.1, where both 2PC and multixact were introduced.
src/backend/access/transam/multixact.c
src/backend/access/transam/twophase.c
src/backend/access/transam/twophase_rmgr.c
src/backend/access/transam/xact.c
src/include/access/multixact.h
src/include/access/twophase.h
src/include/access/twophase_rmgr.h