Track nesting depth correctly when drilling down into RECORD Vars.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 15 Sep 2023 21:01:26 +0000 (17:01 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 15 Sep 2023 21:01:26 +0000 (17:01 -0400)
commitc5b7f791dab95ca14122f7bc09cc729fcaf7e25c
tree3e74059d6368d062b00228a8f88bb38657394337
parent59bc0dfe44a640c88adecc5b97def54b7355abcf
Track nesting depth correctly when drilling down into RECORD Vars.

expandRecordVariable() failed to adjust the parse nesting structure
correctly when recursing to inspect an outer-level Var.  This could
result in assertion failures or core dumps in corner cases.

Likewise, get_name_for_var_field() failed to adjust the deparse
namespace stack correctly when recursing to inspect an outer-level
Var.  In this case the likely result was a "bogus varno" error
while deparsing a view.

Per bug #18077 from Jingzhou Fu.  Back-patch to all supported
branches.

Richard Guo, with some adjustments by me

Discussion: https://postgr.es/m/18077-b9db97c6e0ab45d8@postgresql.org
src/backend/parser/parse_target.c
src/backend/utils/adt/ruleutils.c
src/test/regress/expected/rowtypes.out
src/test/regress/sql/rowtypes.sql