Change the interpretation of the primary_key_attnums parameter of
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Jun 2010 20:29:01 +0000 (20:29 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Jun 2010 20:29:01 +0000 (20:29 +0000)
commitc0989c67fa8fcc53f8475bbc918e330588628cff
tree42432e90967bebf04b5c1b5829ac2f370eef3d3d
parent77a4c51af80819c3bcd581d9237f5c47e68393a6
Change the interpretation of the primary_key_attnums parameter of
dblink_build_sql_insert() and related functions.  Now the column numbers
are treated as logical not physical column numbers.  This will provide saner
behavior in the presence of dropped columns; furthermore, if we ever get
around to allowing rearrangement of logical column ordering, the original
definition would become nearly untenable from a usability standpoint.
Per recent discussion of dblink's handling of dropped columns.
Not back-patched for fear of breaking existing applications.
contrib/dblink/dblink.c
contrib/dblink/expected/dblink.out
contrib/dblink/sql/dblink.sql
doc/src/sgml/dblink.sgml