Fix filtering of unsupported relations in logical replication
authorPeter Eisentraut <peter_e@gmx.net>
Sat, 24 Feb 2018 03:13:21 +0000 (22:13 -0500)
committerPeter Eisentraut <peter_e@gmx.net>
Sat, 24 Feb 2018 03:13:21 +0000 (22:13 -0500)
commitbc1adc651b8e60680aea144d51ae8bc78ea6b2fb
treeebbc39d7c5b03e49ce70faebb1a39a95673d0ad4
parenteec1a8cb6cbc6ea44cf58cfaeaa01ad8ee2bc8e8
Fix filtering of unsupported relations in logical replication

In the pgoutput plugin, skip changes for relations that are not
publishable, per is_publishable_class().  This concerns in particular
materialized views and information_schema tables.  While those relations
cannot be part of a publication, per existing checks, they will be
considered by a FOR ALL TABLES publication.  A subscription would not
actually apply changes for those relations, again per existing checks,
but trying to match incoming changes to local tables on the subscriber
would lead to errors if no matching local table exists.  Skipping those
changes on the publisher avoids sending useless changes and eliminates
the error.

Bug: #15044
Reported-by: Chad Trabant <chad@iris.washington.edu>
Reviewed-by: Petr Jelinek <petr.jelinek@2ndquadrant.com>
src/backend/catalog/pg_publication.c
src/backend/replication/pgoutput/pgoutput.c
src/include/catalog/pg_publication.h
src/test/subscription/t/009_matviews.pl [new file with mode: 0644]