Shut down transaction tracking at startup process exit.
authorFujii Masao <fujii@postgresql.org>
Mon, 5 Apr 2021 17:25:37 +0000 (02:25 +0900)
committerFujii Masao <fujii@postgresql.org>
Mon, 5 Apr 2021 17:27:30 +0000 (02:27 +0900)
commitb59d3abaf4069454fc212660a00b0b1f45c77467
tree37a9fb76ab6d4fc77fdc22f0c2cb2b1630a1a2d7
parent438d7f36ffcc91c81d4e6a4716e556d5bf4f9a78
Shut down transaction tracking at startup process exit.

Maxim Orlov reported that the shutdown of standby server could result in
the following assertion failure. The cause of this issue was that,
when the shutdown caused the startup process to exit, recovery-time
transaction tracking was not shut down even if it's already initialized,
and some locks the tracked transactions were holding could not be released.
At this situation, if other process was invoked and the PGPROC entry that
the startup process used was assigned to it, it found such unreleased locks
and caused the assertion failure, during the initialization of it.

    TRAP: FailedAssertion("SHMQueueEmpty(&(MyProc->myProcLocks[i]))"

This commit fixes this issue by making the startup process shut down
transaction tracking and release all locks, at the exit of it.

Back-patch to all supported branches.

Reported-by: Maxim Orlov
Author: Fujii Masao
Reviewed-by: Maxim Orlov
Discussion: https://postgr.es/m/ad4ce692cc1d89a093b471ab1d969b0b@postgrespro.ru
src/backend/postmaster/startup.c
src/backend/storage/ipc/standby.c