Fix incorrect trigger-property updating in ALTER CONSTRAINT.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 26 Oct 2016 21:05:06 +0000 (17:05 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 26 Oct 2016 21:05:06 +0000 (17:05 -0400)
commitb53c841e5e289a34fde848d44b3d0b2b0ed5cad8
tree9beab1a9cc3c85a74555df6d69131a4fa4e16fca
parent59f5b61cce3cfdfca3dc1a3f68307a47156d6a97
Fix incorrect trigger-property updating in ALTER CONSTRAINT.

The code to change the deferrability properties of a foreign-key constraint
updated all the associated triggers to match; but a moment's examination of
the code that creates those triggers in the first place shows that only
some of them should track the constraint's deferrability properties.  This
leads to odd failures in subsequent exercise of the foreign key, as the
triggers are fired at the wrong times.  Fix that, and add a regression test
comparing the trigger properties produced by ALTER CONSTRAINT with those
you get by creating the constraint as-intended to begin with.

Per report from James Parks.  Back-patch to 9.4 where this ALTER
functionality was introduced.

Report: <CAJ3Xv+jzJ8iNNUcp4RKW8b6Qp1xVAxHwSXVpjBNygjKxcVuE9w@mail.gmail.com>
src/backend/commands/tablecmds.c
src/test/regress/expected/alter_table.out
src/test/regress/sql/alter_table.sql