Don't call PageGetSpecialPointer() on page until it's been initialized.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 30 Jun 2015 10:37:16 +0000 (13:37 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 30 Jun 2015 10:45:00 +0000 (13:45 +0300)
commit7dc721889b31450cad338a189a97ff0ff46534d5
treec357b651276e72d7a85d69f2f0b7a7c84465d8dd
parent1afc1fe9c7bb72652ff9681c2e59a5751a33cda1
Don't call PageGetSpecialPointer() on page until it's been initialized.

After calling XLogInitBufferForRedo(), the page might be all-zeros if it was
not in page cache already. btree_xlog_unlink_page initialized the page
correctly, but it called PageGetSpecialPointer before initializing it, which
would lead to a corrupt page at WAL replay, if the unlinked page is not in
page cache.

Backpatch to 9.4, the bug came with the rewrite of B-tree page deletion.
src/backend/access/nbtree/nbtxlog.c