Fix assignment to array of domain over composite, redux.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 15 Apr 2023 16:01:39 +0000 (12:01 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 15 Apr 2023 16:01:39 +0000 (12:01 -0400)
commit7428aecddf18edc25237eb41257ef023032ce4ad
tree81e3255ae4ce59b1a5395e75740dede5fc0a9396
parent36f49be80856ee46a5ff39c5dc8a7418df63be3d
Fix assignment to array of domain over composite, redux.

Commit 3e310d837 taught isAssignmentIndirectionExpr() to look through
CoerceToDomain nodes.  That's not sufficient, because since commit
04fe805a1 it's been possible for the planner to simplify
CoerceToDomain to RelabelType when the domain has no constraints
to enforce.  So we need to look through RelabelType too.

Per bug #17897 from Alexander Lakhin.  Although 3e310d837 was
back-patched to v11, it seems sufficient to apply this change
to v12 and later, since 04fe805a1 came in in v12.

Dmitry Dolgov

Discussion: https://postgr.es/m/17897-4216c546c3874044@postgresql.org
src/backend/executor/execExpr.c
src/test/regress/expected/domain.out
src/test/regress/sql/domain.sql