Don't assume a subquery's output is unique if there's a SRF in its tlist.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 8 Jul 2014 18:03:19 +0000 (14:03 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 8 Jul 2014 18:03:19 +0000 (14:03 -0400)
commit6d36aee5b718524f718436d0973822bc2cb30bdd
tree894c28440dbcc9b143f33ca57f0fd54a80df74f3
parentf1d7ff5bb8a7beef9afaa311c6f61a37ed4e000e
Don't assume a subquery's output is unique if there's a SRF in its tlist.

While the x output of "select x from t group by x" can be presumed unique,
this does not hold for "select x, generate_series(1,10) from t group by x",
because we may expand the set-returning function after the grouping step.
(Perhaps that should be re-thought; but considering all the other oddities
involved with SRFs in targetlists, it seems unlikely we'll change it.)
Put a check in query_is_distinct_for() so it's not fooled by such cases.

Back-patch to all supported branches.

David Rowley
src/backend/optimizer/util/pathnode.c
src/test/regress/expected/subselect.out
src/test/regress/sql/subselect.sql