Speedup pgstat_report_activity by moving mb-aware truncation to read side.
authorAndres Freund <andres@anarazel.de>
Tue, 19 Sep 2017 18:46:07 +0000 (11:46 -0700)
committerAndres Freund <andres@anarazel.de>
Tue, 19 Sep 2017 19:51:14 +0000 (12:51 -0700)
commit54b6cd589ac2f5635a42511236a5eb7299e2dcaf
treed3ee7ba947177ad35c4ed42bf221bd850b7ea0aa
parentd1687c6926819f023c78b353458950a303796aba
Speedup pgstat_report_activity by moving mb-aware truncation to read side.

Previously multi-byte aware truncation was done on every
pgstat_report_activity() call - proving to be a bottleneck for
workloads with long query strings that execute quickly.

Instead move the truncation to the read side, which commonly is
executed far less frequently. That's possible because all server
encodings allow to determine the length of a multi-byte string from
the first byte.

Rename PgBackendStatus.st_activity to st_activity_raw so existing
extension users of the field break - their code has to be adjusted to
use pgstat_clip_activity().

Author: Andres Freund
Tested-By: Khuntal Ghosh
Reviewed-By: Robert Haas, Tom Lane
Discussion: https://postgr.es/m/20170912071948.pa7igbpkkkviecpz@alap3.anarazel.de
src/backend/postmaster/pgstat.c
src/backend/utils/adt/pgstatfuncs.c
src/include/pgstat.h