Fix corner-case 64-bit integer subtraction bug on some platforms.
authorDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 9 Nov 2023 09:56:31 +0000 (09:56 +0000)
committerDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 9 Nov 2023 09:56:31 +0000 (09:56 +0000)
commit4f4a0010a3a1e0404198130ac3cababeaa17d1e6
treee6613f6d4ed673fa553d1e701d8a771a3362a606
parent319310aa121285b1c7c036cb956a11bcc9d1bcb2
Fix corner-case 64-bit integer subtraction bug on some platforms.

When computing "0 - INT64_MIN", most platforms would report an
overflow error, which is correct. However, platforms without integer
overflow builtins or 128-bit integers would fail to spot the overflow,
and incorrectly return INT64_MIN.

Back-patch to all supported branches.

Patch be me. Thanks to Jian He for initial investigation, and Laurenz
Albe and Tom Lane for review.

Discussion: https://postgr.es/m/CAEZATCUNK-AZSD0jVdgkk0N%3DNcAXBWeAEX-QU9AnJPensikmdQ%40mail.gmail.com
src/include/common/int.h
src/test/regress/expected/int8.out
src/test/regress/sql/int8.sql