Don't allow partitioned index on foreign-table partitions
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 14 May 2018 17:09:32 +0000 (13:09 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 14 May 2018 17:23:07 +0000 (13:23 -0400)
commit4eaa53727542c39cca71b80e8ff3e1f742d64452
tree3ce58902c650466784d36a760a9891cb92d308e7
parentfc2a41e23e10f2338be4907f71c277ea09526680
Don't allow partitioned index on foreign-table partitions

Creating indexes on foreign tables is already forbidden, but local
partitioned indexes (commit 8b08f7d4820f) forgot to check for them.  Add
a preliminary check to prevent wasting time.

Another school of thought says to allow the index to be created if it's
not a unique index; but it's possible to do better in the future (enable
indexing of foreign tables, somehow), so we avoid painting ourselves in
a corner by rejecting all cases, to avoid future grief (a.k.a. backward
incompatible changes).

Reported-by: Arseny Sher
Author: Amit Langote, Álvaro Herrera
Discussion: https://postgr.es/m/87sh71cakz.fsf@ars-thinkpad
src/backend/tcop/utility.c
src/test/regress/expected/foreign_data.out
src/test/regress/sql/foreign_data.sql