Introduce access/{table.h, relation.h}, for generic functions from heapam.h.
authorAndres Freund <andres@anarazel.de>
Mon, 21 Jan 2019 18:14:09 +0000 (10:14 -0800)
committerAndres Freund <andres@anarazel.de>
Mon, 21 Jan 2019 18:51:36 +0000 (10:51 -0800)
commit4b21acf522d751ba5b6679df391d5121b6c4a35f
tree7218c2967f2b376767e45a0f403869c649ed5ef4
parentf1ad067fc3ae3d34dc6b8826913d454cc3fe354f
Introduce access/{table.h, relation.h}, for generic functions from heapam.h.

access/heapam contains functions that are very storage specific (say
heap_insert() and a lot of lower level functions), and fairly generic
infrastructure like relation_open(), heap_open() etc.  In the upcoming
pluggable storage work we're introducing a layer between table
accesses in general and heapam, to allow for different storage
methods. For a bit cleaner separation it thus seems advantageous to
move generic functions like the aforementioned to their own headers.

access/relation.h will contain relation_open() etc, and access/table.h
will contain table_open() (formerly known as heap_open()). I've decided
for table.h not to include relation.h, but we might change that at a
later stage.

relation.h already exists in another directory, but the other
plausible name (rel.h) also conflicts. It'd be nice if there were a
non-conflicting name, but nobody came up with a suggestion. It's
possible that the appropriate way to address the naming conflict would
be to rename nodes/relation.h, which isn't particularly well named.

To avoid breaking a lot of extensions that just use heap_open() etc,
table.h has macros mapping the old names to the new ones, and heapam.h
includes relation, table.h.  That also allows to keep the
bulk renaming of existing callers in a separate commit.

Author: Andres Freund
Discussion: https://postgr.es/m/20190111000539.xbv7s6w7ilcvm7dp@alap3.anarazel.de
src/backend/access/Makefile
src/backend/access/common/Makefile
src/backend/access/common/relation.c [new file with mode: 0644]
src/backend/access/heap/heapam.c
src/backend/access/table/Makefile [new file with mode: 0644]
src/backend/access/table/table.c [new file with mode: 0644]
src/include/access/heapam.h
src/include/access/relation.h [new file with mode: 0644]
src/include/access/table.h [new file with mode: 0644]