Relax overly strict sanity check for upgraded ancient databases
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 1 Mar 2018 21:07:46 +0000 (18:07 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 1 Mar 2018 21:07:46 +0000 (18:07 -0300)
commit477ad05e165c15dc9241376f0fce9664063cff46
tree1a969e5bed82ab3300e7ad6438f54484a3534f76
parentb5febc1d125cac37c626cb7c96936db6839ec733
Relax overly strict sanity check for upgraded ancient databases

Commit 4800f16a7ad0 added some sanity checks to ensure we don't
accidentally corrupt data, but in one of them we failed to consider the
effects of a database upgraded from 9.2 or earlier, where a tuple
exclusively locked prior to the upgrade has a slightly different bit
pattern.  Fix that by using the macro that we fixed in commit
74ebba84aeb6 for similar situations.

Reported-by: Alexandre Garcia
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/CAPYLKR6yxV4=pfW0Gwij7aPNiiPx+3ib4USVYnbuQdUtmkMaEA@mail.gmail.com

Andres suspects that this bug may have wider ranging consequences, but I
couldn't find anything.
src/backend/access/heap/heapam.c