Allow using the updated tuple while moving it to a different partition.
authorAmit Kapila <akapila@postgresql.org>
Thu, 12 Jul 2018 07:21:39 +0000 (12:51 +0530)
committerAmit Kapila <akapila@postgresql.org>
Thu, 12 Jul 2018 07:21:39 +0000 (12:51 +0530)
commit40ca70ebcc9d0bc1c02937b27c44b2766617e790
tree3fe65a78397130769917447dd610f1859a6c099c
parentedc6b41bd4a80ea6aebacbd86ebe7c3a01939789
Allow using the updated tuple while moving it to a different partition.

An update that causes the tuple to be moved to a different partition was
missing out on re-constructing the to-be-updated tuple, based on the latest
tuple in the update chain.  Instead, it's simply deleting the latest tuple
and inserting a new tuple in the new partition based on the old tuple.
Commit 2f17844104 didn't consider this case, so some of the updates were
getting lost.

In passing, change the argument order for output parameter in ExecDelete
and add some commentary about it.

Reported-by: Pavan Deolasee
Author: Amit Khandekar, with minor changes by me
Reviewed-by: Dilip Kumar, Amit Kapila and Alvaro Herrera
Backpatch-through: 11
Discussion: https://postgr.es/m/CAJ3gD9fRbEzDqdeDq1jxqZUb47kJn+tQ7=Bcgjc8quqKsDViKQ@mail.gmail.com
src/backend/commands/trigger.c
src/backend/executor/execReplication.c
src/backend/executor/nodeModifyTable.c
src/include/commands/trigger.h
src/test/isolation/expected/partition-key-update-4.out [new file with mode: 0644]
src/test/isolation/isolation_schedule
src/test/isolation/specs/partition-key-update-4.spec [new file with mode: 0644]