Fix file descriptor leak after failure of a \setshell command in pgbench.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 16 Dec 2014 18:31:42 +0000 (13:31 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 16 Dec 2014 18:32:02 +0000 (13:32 -0500)
commit3b750ec155be3b8d658eadd8effe4d3c31955852
tree9db05f8303193431f6feb568e91a7312f0934090
parentea78d1381e01d96bb7d6426f25b8033fd11b9c14
Fix file descriptor leak after failure of a \setshell command in pgbench.

If the called command fails to return data, runShellCommand forgot to
pclose() the pipe before returning.  This is fairly harmless in the current
code, because pgbench would then abandon further processing of that client
thread; so no more than nclients descriptors could be leaked this way.  But
it's not hard to imagine future improvements whereby that wouldn't be true.
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.
contrib/pgbench/pgbench.c