Add missing EmitWarningsOnPlaceholders() calls.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 21 Dec 2021 17:12:24 +0000 (12:12 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 21 Dec 2021 17:12:24 +0000 (12:12 -0500)
commit1fada5d81e6769ded832a4ca62ee9371bac3fb9f
treeb645a3f7fc4340bcc0e6596309231c356a216d86
parent0e6e7f0806b2080cb31f33ff992ec2e4e35fa6f1
Add missing EmitWarningsOnPlaceholders() calls.

Extensions that define any custom GUCs should call
EmitWarningsOnPlaceholders after doing so, to help catch misspellings.
Many of our contrib modules hadn't gotten the memo on that, though.

Also add such calls to src/test/modules extensions that have GUCs.
While these aren't really user-facing, they should illustrate good
practice not faulty practice.

Shinya Kato

Discussion: https://postgr.es/m/524fa2c0a34f34b68fbfa90d0760d515@oss.nttdata.com
contrib/auth_delay/auth_delay.c
contrib/pg_trgm/trgm_op.c
contrib/postgres_fdw/option.c
contrib/sepgsql/hooks.c
src/backend/utils/misc/guc.c
src/pl/tcl/pltcl.c
src/test/modules/delay_execution/delay_execution.c
src/test/modules/ssl_passphrase_callback/ssl_passphrase_func.c
src/test/modules/worker_spi/worker_spi.c