From f27eb0325b7b2cff3b880fa669913693849521dc Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 10 Apr 2025 14:18:07 -0400 Subject: [PATCH] Remove useless check for negative result of ip_addrsize(). By inspection, ip_addrsize() can't return a negative result. (If it could, we'd have way bigger problems elsewhere.) So delete useless check in network_send(). Most C compilers are probably perfectly capable of removing this code by themselves, but it's confusing/misleading. Bug: #18889 Reported-by: Daniel Elishakov Discussion: https://postgr.es/m/18889-73d4f19e953a629e@postgresql.org --- src/backend/utils/adt/network.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/backend/utils/adt/network.c b/src/backend/utils/adt/network.c index 227980c14d3..f03fcc1147b 100644 --- a/src/backend/utils/adt/network.c +++ b/src/backend/utils/adt/network.c @@ -279,8 +279,6 @@ network_send(inet *addr, bool is_cidr) pq_sendbyte(&buf, ip_bits(addr)); pq_sendbyte(&buf, is_cidr); nb = ip_addrsize(addr); - if (nb < 0) - nb = 0; pq_sendbyte(&buf, nb); addrptr = (char *) ip_addr(addr); for (i = 0; i < nb; i++) -- 2.39.5