From ee5a701f1cbe6783376f277b4052db05fc0f95b2 Mon Sep 17 00:00:00 2001 From: Magnus Hagander Date: Tue, 31 Mar 2020 20:08:41 +0200 Subject: [PATCH] Specify on_delete=models.CASCADE on all ForeignKey fields --- gitadmin/gitadmin/adm/migrations/0001_initial.py | 6 +++--- gitadmin/gitadmin/adm/models.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gitadmin/gitadmin/adm/migrations/0001_initial.py b/gitadmin/gitadmin/adm/migrations/0001_initial.py index 60046d6..f0ded83 100644 --- a/gitadmin/gitadmin/adm/migrations/0001_initial.py +++ b/gitadmin/gitadmin/adm/migrations/0001_initial.py @@ -54,7 +54,7 @@ class Migration(migrations.Migration): ('approved', models.BooleanField(default=False)), ('tabwidth', models.IntegerField(default=8)), ('initialclone', models.CharField(max_length=256, null=True, blank=True)), - ('remoterepository', models.ForeignKey(verbose_name='Remote repository', blank=True, to='adm.RemoteRepository', null=True)), + ('remoterepository', models.ForeignKey(verbose_name='Remote repository', blank=True, to='adm.RemoteRepository', null=True, on_delete=models.CASCADE)), ], options={ 'db_table': 'repositories', @@ -67,7 +67,7 @@ class Migration(migrations.Migration): ('id', models.AutoField(verbose_name='ID', serialize=False, auto_created=True, primary_key=True)), ('userid', models.CharField(max_length=255, verbose_name="User id")), ('level', models.IntegerField(default=0, verbose_name='Permission', choices=[(0, 'Read'), (1, 'Write'), (2, 'Owner')])), - ('repository', models.ForeignKey(to='adm.Repository', db_column='repository')), + ('repository', models.ForeignKey(to='adm.Repository', db_column='repository', on_delete=models.CASCADE)), ], options={ 'db_table': 'repository_permissions', @@ -76,7 +76,7 @@ class Migration(migrations.Migration): migrations.AddField( model_name='remoterepository', name='repotype', - field=models.ForeignKey(to='adm.RemoteRepositoryType'), + field=models.ForeignKey(to='adm.RemoteRepositoryType', on_delete=models.CASCADE), ), migrations.AlterUniqueTogether( name='repositorypermission', diff --git a/gitadmin/gitadmin/adm/models.py b/gitadmin/gitadmin/adm/models.py index f7245e4..15ebffe 100644 --- a/gitadmin/gitadmin/adm/models.py +++ b/gitadmin/gitadmin/adm/models.py @@ -19,7 +19,7 @@ class RemoteRepositoryType(models.Model): class RemoteRepository(models.Model): - repotype = models.ForeignKey(RemoteRepositoryType, null=False) + repotype = models.ForeignKey(RemoteRepositoryType, null=False, on_delete=models.CASCADE) remoteurl = models.CharField(max_length=256, blank=False) # rsync or cvs remotemodule = models.CharField(max_length=32, blank=False) lastsynced = models.DateTimeField(null=False, default=datetime.datetime.now) @@ -41,7 +41,7 @@ class Repository(models.Model): approved = models.BooleanField(blank=False, default=False) tabwidth = models.IntegerField(default=8, null=False) initialclone = models.CharField(max_length=256, blank=True, null=True) - remoterepository = models.ForeignKey(RemoteRepository, null=True, blank=True, + remoterepository = models.ForeignKey(RemoteRepository, null=True, blank=True, on_delete=models.CASCADE, verbose_name='Remote repository') def ValidateOwnerPermissions(self, user): @@ -57,7 +57,7 @@ class Repository(models.Model): class RepositoryPermission(models.Model): - repository = models.ForeignKey(Repository, db_column='repository') + repository = models.ForeignKey(Repository, db_column='repository', on_delete=models.CASCADE) userid = models.CharField(max_length=255, blank=False, verbose_name="User id") level = models.IntegerField(default=0, verbose_name='Permission', choices=PERMISSION_CHOICES) -- 2.39.5