From dc084d7c730c93541a386851de9c62bd0e9a0c92 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Sat, 29 Jan 2022 10:22:42 +0900 Subject: [PATCH] Fix incorrect memory context switch in COPY TO execution c532d15 has split the logic of COPY commands into multiple files, one change being to move the internals of BeginCopy() to BeginCopyTo(). Originally the code was written so as we'd switch back-and-forth between the current execution memory context and the dedicated memory context for the COPY command, and this refactoring has introduced an extra switch to the current memory context from the COPY context once BeginCopyTo() is done with the past logic coming from BeginCopy(). The code was correctly doing the analyze, rewrite and planning phases in the COPY context, but it was not assigning "copy_file" (FILE* used when copying to a source file) and "filename" in the COPY context, making the COPY status data inconsistent. Author: Bharath Rupireddy Reviewed-by: Japin Li Discussion: https://postgr.es/m/CALj2ACWvVa69foi9jhHFY=2BuHxAoYboyE+vXQTARwxZcJnVrQ@mail.gmail.com Backpatch-through: 14 --- src/backend/commands/copyto.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/backend/commands/copyto.c b/src/backend/commands/copyto.c index e793b64bda..3283ef50d0 100644 --- a/src/backend/commands/copyto.c +++ b/src/backend/commands/copyto.c @@ -657,8 +657,6 @@ BeginCopyTo(ParseState *pstate, cstate->copy_dest = COPY_FILE; /* default */ - MemoryContextSwitchTo(oldcontext); - if (pipe) { progress_vals[1] = PROGRESS_COPY_TYPE_PIPE; -- 2.39.5