Make DROP DATABASE command generate less WAL records.
authorFujii Masao <fujii@postgresql.org>
Thu, 21 Nov 2019 12:10:37 +0000 (21:10 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 21 Nov 2019 12:10:37 +0000 (21:10 +0900)
commite6d8069522c8bde8239dd1fedfb4984efa4b3a1a
treeb0d38edfd892bdd52f3086616c36d1bce5d350ab
parent30840c92ac0c4073fb7bc8222317630571b8cf25
Make DROP DATABASE command generate less WAL records.

Previously DROP DATABASE generated as many XLOG_DBASE_DROP WAL records
as the number of tablespaces that the database to drop uses. This caused
the scans of shared_buffers as many times as the number of the tablespaces
during recovery because WAL replay of one XLOG_DBASE_DROP record needs
that full scan. This could make the recovery time longer especially
when shared_buffers is large.

This commit changes DROP DATABASE so that it generates only one
XLOG_DBASE_DROP record, and registers the information of all the tablespaces
into it. Then, WAL replay of XLOG_DBASE_DROP record needs full scan of
shared_buffers only once, and which may improve the recovery performance.

Author: Fujii Masao
Reviewed-by: Kirk Jamison, Simon Riggs
Discussion: https://postgr.es/m/CAHGQGwF8YwNH0ZaL+2wjZPkj+ji9UhC+Z4ScnG97WKtVY5L9iw@mail.gmail.com
src/backend/access/rmgrdesc/dbasedesc.c
src/backend/commands/dbcommands.c
src/include/commands/dbcommands_xlog.h