Avoid looping over all type cache entries in TypeCacheRelCallback()
authorAlexander Korotkov <akorotkov@postgresql.org>
Sun, 25 Aug 2024 00:21:23 +0000 (03:21 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Sun, 25 Aug 2024 00:21:23 +0000 (03:21 +0300)
commitc14d4acb81348a34497b53a19dce2924cc4f6551
tree69a399adfa4f0b28c8f31987392973a35bf6df12
parent3890d90c1508125729ed20038d90513694fc3a7b
Avoid looping over all type cache entries in TypeCacheRelCallback()

Currently when a single relcache entry gets invalidated,
TypeCacheRelCallback() has to loop over all type cache entries to find
appropriate typentry to invalidate.  Unfortunately, using the syscache here
is impossible, because this callback could be called outside a transaction
and this makes impossible catalog lookups.  This is why present commit
introduces RelIdToTypeIdCacheHash to map relation OID to its composite type
OID.

We are keeping RelIdToTypeIdCacheHash entry while corresponding type cache
entry have something to clean.  Therefore, RelIdToTypeIdCacheHash shouldn't
get bloat in the case of temporary tables flood.

Discussion: https://postgr.es/m/5812a6e5-68ae-4d84-9d85-b443176966a1%40sigaev.ru
Author: Teodor Sigaev
Reviewed-by: Aleksander Alekseev, Tom Lane, Michael Paquier, Roman Zharkov
Reviewed-by: Andrei Lepikhov, Pavel Borisov
src/backend/utils/cache/typcache.c
src/tools/pgindent/typedefs.list