Avoid holding a directory FD open across assorted SRF calls.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 17 Mar 2020 01:05:28 +0000 (21:05 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 17 Mar 2020 01:05:52 +0000 (21:05 -0400)
commitb4570d33aa045df330bb325ba8a2cbf02266a555
tree4e7ebfee102862d095bfa9eb0dede58a4cca471f
parent113758155c11cf993ca0ecee8856e300a2525a30
Avoid holding a directory FD open across assorted SRF calls.

This extends the fixes made in commit 085b6b667 to other SRFs with the
same bug, namely pg_logdir_ls(), pgrowlocks(), pg_timezone_names(),
pg_ls_dir(), and pg_tablespace_databases().

Also adjust various comments and documentation to warn against
expecting to clean up resources during a ValuePerCall SRF's final
call.

Back-patch to all supported branches, since these functions were
all born broken.

Justin Pryzby, with cosmetic tweaks by me

Discussion: https://postgr.es/m/20200308173103.GC1357@telsasoft.com
contrib/adminpack/adminpack.c
contrib/pgrowlocks/pgrowlocks.c
doc/src/sgml/xfunc.sgml
src/backend/utils/adt/datetime.c
src/backend/utils/adt/genfile.c
src/backend/utils/adt/misc.c
src/backend/utils/fmgr/README
src/include/funcapi.h
src/test/regress/expected/misc_functions.out
src/test/regress/sql/misc_functions.sql