Remove MaxBackends variable in favor of GetMaxBackends() function.
authorRobert Haas <rhaas@postgresql.org>
Tue, 8 Feb 2022 20:52:40 +0000 (15:52 -0500)
committerRobert Haas <rhaas@postgresql.org>
Tue, 8 Feb 2022 20:53:19 +0000 (15:53 -0500)
commitaa64f23b02924724eafbd9eadbf26d85df30a12b
tree54f72bfd7e36c2e879dc87149eb94db220d1cae3
parent2da896182ce11240774af6c4d769777f90a09536
Remove MaxBackends variable in favor of GetMaxBackends() function.

Previously, it was really easy to write code that accessed MaxBackends
before we'd actually initialized it, especially when coding up an
extension. To make this less error-prune, introduce a new function
GetMaxBackends() which should be used to obtain the correct value.
This will ERROR if called too early. Demote the global variable to
a file-level static, so that nobody can peak at it directly.

Nathan Bossart. Idea by Andres Freund. Review by Greg Sabino Mullane,
by Michael Paquier (who had doubts about the approach), and by me.

Discussion: http://postgr.es/m/20210802224204.bckcikl45uezv5e4@alap3.anarazel.de
19 files changed:
src/backend/access/nbtree/nbtutils.c
src/backend/access/transam/multixact.c
src/backend/access/transam/twophase.c
src/backend/commands/async.c
src/backend/libpq/pqcomm.c
src/backend/postmaster/auxprocess.c
src/backend/postmaster/postmaster.c
src/backend/storage/ipc/dsm.c
src/backend/storage/ipc/procarray.c
src/backend/storage/ipc/procsignal.c
src/backend/storage/ipc/sinvaladt.c
src/backend/storage/lmgr/deadlock.c
src/backend/storage/lmgr/lock.c
src/backend/storage/lmgr/predicate.c
src/backend/storage/lmgr/proc.c
src/backend/utils/activity/backend_status.c
src/backend/utils/adt/lockfuncs.c
src/backend/utils/init/postinit.c
src/include/miscadmin.h