Fix busted tab completion of extension versions.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 18 Jun 2022 23:45:38 +0000 (19:45 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 18 Jun 2022 23:45:38 +0000 (19:45 -0400)
commit9cd43f6cbd8b6fbac6837bcdba5e12f0ecbafefb
tree83bcfe25521d671dad3b3300134e4d3e64c8d0e4
parent7bd4a9e9901966fb35acd509af0d468881aa5d22
Fix busted tab completion of extension versions.

In 02b8048ba I (tgl) got rid of the need for most tab-completion queries
to return pre-quoted identifiers.  But I over-hastily removed the
quote_ident call from Query_for_list_of_available_extension_versions*
too; those still need it, because what is returned isn't an identifier
at all and will (almost?) always need quoting.

Arguably we should use quote_literal here instead.  But quote_ident
works too and people may be used to that behavior, so stick with it.

In passing, fix inconsistent omission of schema-qualification in
Query_for_list_of_encodings.  That's not a security issue per our
current guidelines, but it ought to be like the rest.

Jeff Janes

Discussion: https://postgr.es/m/CAMkU=1yV+egSYrzWvbDY8VZ6bKEMrKbzxr-HTuiHi+wDgSUMgA@mail.gmail.com
src/bin/psql/tab-complete.c