Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.
authorNoah Misch <noah@leadboat.com>
Sat, 30 Jan 2021 08:00:27 +0000 (00:00 -0800)
committerNoah Misch <noah@leadboat.com>
Sat, 30 Jan 2021 08:00:27 +0000 (00:00 -0800)
commit8a54e12a38d1545d249f1402f66c8cde2837d97c
treed6b155a68f9e3dc21f1061106320c620eeaeb6ed
parentf77717b2985aa529a185e6988de26b885ca10ddb
Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.

In a cluster having used CREATE INDEX CONCURRENTLY while having enabled
prepared transactions, queries that use the resulting index can silently
fail to find rows.  Fix this for future CREATE INDEX CONCURRENTLY by
making it wait for prepared transactions like it waits for ordinary
transactions.  This expands the VirtualTransactionId structure domain to
admit prepared transactions.  It may be necessary to reindex to recover
from past occurrences.  Back-patch to 9.5 (all supported versions).

Andrey Borodin, reviewed (in earlier versions) by Tom Lane and Michael
Paquier.

Discussion: https://postgr.es/m/2E712143-97F7-4890-B470-4A35142ABC82@yandex-team.ru
src/backend/storage/lmgr/lmgr.c
src/backend/storage/lmgr/lock.c
src/include/storage/lock.h
src/test/isolation/Makefile
src/test/isolation/README
src/test/isolation/expected/prepared-transactions-cic.out [new file with mode: 0644]
src/test/isolation/specs/prepared-transactions-cic.spec [new file with mode: 0644]