Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 15 Oct 2020 17:32:34 +0000 (14:32 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 15 Oct 2020 17:32:34 +0000 (14:32 -0300)
commit85adb5e91ec2f45a388bef7a92a3d988c7e45501
tree1016833115e7e87ffff759fe2ba8ffce7c78a7a2
parent2203ede9ae85b6423f850466122606275ea09b17
Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls

Pavan Deolasee recently noted that a few of the
HeapTupleHeaderIndicatesMovedPartitions calls added by commit
5db6df0c0117 are useless, since they are done after comparing t_self
with t_ctid.  But because t_self can never be set to the magical values
that indicate that the tuple moved partition, this can never succeed: if
the first test fails (so we know t_self equals t_ctid), necessarily the
second test will also fail.

So these checks can be removed and no harm is done.

Discussion: https://postgr.es/m/20200929164411.GA15497@alvherre.pgsql
src/backend/access/heap/heapam.c
src/backend/access/heap/heapam_visibility.c