Fix initialization of RelationSyncEntry for streaming transactions.
authorAmit Kapila <akapila@postgresql.org>
Wed, 16 Sep 2020 02:15:44 +0000 (07:45 +0530)
committerAmit Kapila <akapila@postgresql.org>
Wed, 16 Sep 2020 02:15:44 +0000 (07:45 +0530)
commit69bd60672af63eaa8b19cdcea175df5ff172e80e
tree856f37db90e426cb2159742847adc716f3b6fd13
parent19c60ad69a91f346edf66996b2cf726f594d3d2b
Fix initialization of RelationSyncEntry for streaming transactions.

In commit 464824323e, for each RelationSyncEntry we maintained the list
of xids (streamed_txns) for which we have already sent the schema. This
helps us to track when to send the schema to the downstream node for
replication of streaming transactions. Before this list got initialized,
we were processing invalidation messages which access this list and led
to an assertion failure.

In passing, clean up the nearby code:

* Initialize the list of xids with NIL instead of NULL which is our usual
coding practice.
* Remove the MemoryContext switch for creating a RelationSyncEntry in dynahash.

Diagnosed-by: Amit Kapila and Tom Lane
Author: Amit Kapila
Reviewed-by: Tom Lane and Dilip Kumar
Discussion: https://postgr.es/m/904373.1600033123@sss.pgh.pa.us
src/backend/replication/pgoutput/pgoutput.c